Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2338483005: cros: Fix "Add person" long delay regression (Closed)

Created:
4 years, 3 months ago by xiyuan
Modified:
4 years, 3 months ago
Reviewers:
waffles
CC:
chromium-reviews, Greg K
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Fix "Add person" long delay regression The long delay is caused by plugin data removal timed out, which is caused by the fake Flash plugin. ChromeOS should not use the fake Flash plugin since its Flash is bundled. BUG=644400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/common/chrome_content_client.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
xiyuan
This fixes http://crbug.com/644400. WDYT?
4 years, 3 months ago (2016-09-13 21:59:59 UTC) #4
xiyuan
ping?
4 years, 3 months ago (2016-09-15 16:10:11 UTC) #7
waffles
On 2016/09/15 16:10:11, xiyuan wrote: > ping? Sorry, I was on leave. It looks like ...
4 years, 3 months ago (2016-09-15 17:19:22 UTC) #8
xiyuan
On 2016/09/15 17:19:22, waffles wrote: > On 2016/09/15 16:10:11, xiyuan wrote: > > ping? > ...
4 years, 3 months ago (2016-09-15 17:22:33 UTC) #10
xiyuan
4 years, 3 months ago (2016-09-15 17:57:19 UTC) #11
On 2016/09/15 17:22:33, xiyuan wrote:
> On 2016/09/15 17:19:22, waffles wrote:
> > On 2016/09/15 16:10:11, xiyuan wrote:
> > > ping?
> > 
> > Sorry, I was on leave.
> > 
> > It looks like this will also be fixed by
> > https://codereview.chromium.org/2340643002/, the idea being that
> > FLAPPER_AVAILABLE will no longer be defined on ChromeOS - how do you feel
> about
> > checking in that change only?
> 
> I am fine with the CL as long as it fixes the long delay problem. Thanks for
the
> pointer. I will give the CL try.

Yep, the CL fixes the long delay problem. I will abandon this CL then.

Powered by Google App Engine
This is Rietveld 408576698