Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java

Issue 2338473002: [Remoting Android] JniGlDisplayHandler calls invalidate() on UI thread (Closed)
Patch Set: null-check ui_task_poster_ before using it Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java b/remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java
index dedbbb4e0361a6c33121c0b22a15f8cd5dc2cdb8..30281d5768401adbae8390b2f2f9818f83ebca3f 100644
--- a/remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java
+++ b/remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java
@@ -26,11 +26,11 @@ import org.chromium.chromoting.SizeChangedEventParameter;
*
* This class works entirely on the UI thread:
* Functions should all be called on UI.
- * Events will only be triggered on UI.
+ * Callbacks by native counterpart are called on UI.
*/
@JNINamespace("remoting")
public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
- private volatile long mNativeJniGlDisplay;
+ private long mNativeJniGlDisplay;
private final Event.Raisable<SizeChangedEventParameter> mOnClientSizeChanged =
new Event.Raisable<>();
private final Event.Raisable<SizeChangedEventParameter> mOnHostSizeChanged =
@@ -45,8 +45,7 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
}
/**
- * Invalidates this object and disconnects from the native display handler. Called on the
- * display thread by the native code.
+ * Invalidates this object and disconnects from the native display handler.
*/
@CalledByNative
private void invalidate() {
« no previous file with comments | « no previous file | remoting/client/jni/display_updater_factory.h » ('j') | remoting/client/jni/display_updater_factory.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698