Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java

Issue 2338473002: [Remoting Android] JniGlDisplayHandler calls invalidate() on UI thread (Closed)
Patch Set: Reviewer's Feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/client/jni/chromoting_jni_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java b/remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java
index e7dae04a790e3644e16b3b9f558f0af6eb526bcf..a608b5974f5576cf0132a617980885b36e204d41 100644
--- a/remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java
+++ b/remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java
@@ -22,8 +22,7 @@ import org.chromium.chromoting.SizeChangedEventParameter;
* the remote desktop. The lifetime of this class is managed by the native JniGlDisplayHandler.
*
* This class works entirely on the UI thread:
- * Functions should all be called on UI.
- * Events will only be triggered on UI.
+ * All functions, including callbacks from native code are called only on UI thread.
*/
@JNINamespace("remoting")
public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
@@ -33,7 +32,7 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
new Event.Raisable<>();
private final Event.Raisable<Void> mOnCanvasRendered = new Event.Raisable<>();
- private volatile long mNativeJniGlDisplay;
+ private long mNativeJniGlDisplay;
private InputFeedbackRadiusMapper mFeedbackRadiusMapper;
private float mScaleFactor = 0;
@@ -42,8 +41,7 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
}
/**
- * Invalidates this object and disconnects from the native display handler. Called on the
- * display thread by the native code.
+ * Invalidates this object and disconnects from the native display handler.
*/
@CalledByNative
private void invalidate() {
« no previous file with comments | « no previous file | remoting/client/jni/chromoting_jni_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698