Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java

Issue 2338473002: [Remoting Android] JniGlDisplayHandler calls invalidate() on UI thread (Closed)
Patch Set: Remove DisplayUpdaterFactory Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java b/remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java
index e7dae04a790e3644e16b3b9f558f0af6eb526bcf..3f439e064da0ea198d6b56e01631843ef459ff85 100644
--- a/remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java
+++ b/remoting/android/java/src/org/chromium/chromoting/jni/GlDisplay.java
@@ -23,7 +23,7 @@ import org.chromium.chromoting.SizeChangedEventParameter;
*
* This class works entirely on the UI thread:
* Functions should all be called on UI.
- * Events will only be triggered on UI.
+ * Callbacks by native counterpart are called on UI.
Sergey Ulanov 2016/09/20 18:09:34 s/UI/the UI thread/ Or maybe rephrase the whole co
Yuwei 2016/09/20 19:20:37 Done.
*/
@JNINamespace("remoting")
public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
@@ -33,7 +33,7 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
new Event.Raisable<>();
private final Event.Raisable<Void> mOnCanvasRendered = new Event.Raisable<>();
- private volatile long mNativeJniGlDisplay;
+ private long mNativeJniGlDisplay;
private InputFeedbackRadiusMapper mFeedbackRadiusMapper;
private float mScaleFactor = 0;
@@ -42,8 +42,7 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
}
/**
- * Invalidates this object and disconnects from the native display handler. Called on the
- * display thread by the native code.
+ * Invalidates this object and disconnects from the native display handler.
*/
@CalledByNative
private void invalidate() {
« no previous file with comments | « no previous file | remoting/client/jni/chromoting_jni_instance.cc » ('j') | remoting/client/jni/jni_gl_display_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698