[Remoting Android] JniGlDisplayHandler calls invalidate() on UI thread

remoting/client/jni/display_updater_factory.h

Index: remoting/client/jni/display_updater_factory.h
diff --git a/remoting/client/jni/display_updater_factory.h b/remoting/client/jni/display_updater_factory.h
index 9826e96117137831fd4f7e5d1928deef7508fcdc..881106ffca082eb877ae6fb3e190a246ec76df82 100644
--- a/remoting/client/jni/display_updater_factory.h
+++ b/remoting/client/jni/display_updater_factory.h
@@ -21,13 +21,24 @@ class VideoRenderer;
 // returned object should be used on the network thread.
 class DisplayUpdaterFactory {

[Sergey Ulanov, 2016/09/19 21:14:56]

Do we need to keep this interface? I think we needed it to support two
capturers, but I don't think we will need this going forward, so maybe we can
just remove it?

[Yuwei, 2016/09/19 23:52:10]

That's what I have considered. Removed.

  public:
-  virtual ~DisplayUpdaterFactory() {}
+  // A deleter that calls Destroy() to delete the factory.

[Lambros, 2016/09/16 01:44:12]

Does it make sense for this deleter (and Destroy method) to be here in the
interface, instead of in JniGlDisplayHandler?

[Yuwei, 2016/09/16 21:49:44]

I don't have a strong opinion. My justifications are:

1. Anyone who needs to create a reset-able unique_ptr will need such a deleter
2. Currently JniClient references to the DisplayHandler as the interface so
Destroy() probably can't be removed from the interface. Also arguably it may be
good if any future renderer implementations can have a chance to handle the
destroy process by itself.

+  struct Deleter {
+    void operator()(DisplayUpdaterFactory* factory) {
+      if (factory) {
+        factory->Destroy();
+      }
+    }
+  };
 
   virtual std::unique_ptr<protocol::CursorShapeStub>
   CreateCursorShapeStub() = 0;
   virtual std::unique_ptr<protocol::VideoRenderer> CreateVideoRenderer() = 0;
 
+  // Destroys the factory object and frees the memory.
+  virtual void Destroy() = 0;
+
  protected:
+  virtual ~DisplayUpdaterFactory() {}
   DisplayUpdaterFactory() {}
 
  private: