Improve compile time constant evaluation

Improve compile time constant evaluation

Eliminate the need to invoke an execute-once function to compute
type literals and implicit closures. This reduces the number of
execute-once invocations from 6000 to 60 when compiling all of
the greentea sources, about 1MB of generated code. Sadly, no
significant runtime gain was observed.

Also simplify the caching of computed compile-time constants.

Reinstate the compiler stat counter for number of constants cached.



BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/3829c00e109c622e883e031c7f7757ee5703eb54

[hausner, 2016-09-12 22:03:20]

Description was changed from

==========
Improve compile time constant evaluation

Eliminate the need to invoke an execute-once function to compute
type literals and implicit closures. This reduces the number of
execute-once invocations from 6000 to 60 when compiling all of
the greentea sources, about 1MB of generated code. Sadly, no
significant runtime gain was observed.

Also simplify the caching of computed compile-time constants.


BUG=
==========

to

==========
Improve compile time constant evaluation

Eliminate the need to invoke an execute-once function to compute
type literals and implicit closures. This reduces the number of
execute-once invocations from 6000 to 60 when compiling all of
the greentea sources, about 1MB of generated code. Sadly, no
significant runtime gain was observed.

Also simplify the caching of computed compile-time constants.

Reinstate the compiler stat counter for number of constants cached.



BUG=
==========

[hausner, 2016-09-12 22:03:20]

hausner@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-09-12 22:33:25]

LGTM

https://chromiumcodereview.appspot.com/2338463003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/2338463003/diff/1/runtime/vm/parser.cc...
runtime/vm/parser.cc:14470: Instance& closure = Instance::ZoneHandle(Z,
func.ImplicitStaticClosure());
I think you can assert the closure is already canonical here.

[hausner, 2016-09-12 23:00:54]

https://chromiumcodereview.appspot.com/2338463003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/2338463003/diff/1/runtime/vm/parser.cc...
runtime/vm/parser.cc:14470: Instance& closure = Instance::ZoneHandle(Z,
func.ImplicitStaticClosure());
On 2016/09/12 22:33:25, rmacnak wrote:
> I think you can assert the closure is already canonical here.

Done.

[hausner, 2016-09-12 23:02:40]

https://chromiumcodereview.appspot.com/2338463003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/2338463003/diff/1/runtime/vm/parser.cc...
runtime/vm/parser.cc:14470: Instance& closure = Instance::ZoneHandle(Z,
func.ImplicitStaticClosure());
On 2016/09/12 23:00:54, hausner wrote:
> On 2016/09/12 22:33:25, rmacnak wrote:
> > I think you can assert the closure is already canonical here.
> 
> Done.

Spoke too soon. The tests trip of the assertion, so canonicalization is needed
here.

[hausner, 2016-09-12 23:23:06]

Description was changed from

==========
Improve compile time constant evaluation

Eliminate the need to invoke an execute-once function to compute
type literals and implicit closures. This reduces the number of
execute-once invocations from 6000 to 60 when compiling all of
the greentea sources, about 1MB of generated code. Sadly, no
significant runtime gain was observed.

Also simplify the caching of computed compile-time constants.

Reinstate the compiler stat counter for number of constants cached.



BUG=
==========

to

==========
Improve compile time constant evaluation

Eliminate the need to invoke an execute-once function to compute
type literals and implicit closures. This reduces the number of
execute-once invocations from 6000 to 60 when compiling all of
the greentea sources, about 1MB of generated code. Sadly, no
significant runtime gain was observed.

Also simplify the caching of computed compile-time constants.

Reinstate the compiler stat counter for number of constants cached.



BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3829c00e109c622e883e031c7f7757ee5703eb54
==========

[hausner, 2016-09-12 23:23:07]

Committed patchset #2 (id:20001) manually as
3829c00e109c622e883e031c7f7757ee5703eb54.