Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 233843003: Remove a few dead MSVS_VERSION checks. (Closed)

Created:
6 years, 8 months ago by Nico
Modified:
6 years, 8 months ago
Reviewers:
robertshield, scottmg
CC:
chromium-reviews, grt+watch_chromium.org, hans
Visibility:
Public.

Description

Remove a few dead MSVS_VERSION checks. We only support 2013. TBR=robertshield@chromium.org BUG=340358 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263460

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -134 lines) Patch
M build/common.gypi View 1 4 chunks +2 lines, -36 lines 0 comments Download
M chrome/installer/mini_installer.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M testing/gtest.gyp View 1 chunk +0 lines, -10 lines 0 comments Download
M win8/delegate_execute/delegate_execute.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M win8/metro_driver/metro_driver.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D win8/util/check_sdk_patch.py View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
M win8/win8.gyp View 1 2 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Nico
6 years, 8 months ago (2014-04-10 22:10:27 UTC) #1
scottmg
lgtm (i added a bug link) https://codereview.chromium.org/233843003/diff/20001/win8/win8.gyp File win8/win8.gyp (left): https://codereview.chromium.org/233843003/diff/20001/win8/win8.gyp#oldcode13 win8/win8.gyp:13: 'target_name': 'check_sdk_patch', can ...
6 years, 8 months ago (2014-04-10 22:20:43 UTC) #2
Nico
Thanks! https://codereview.chromium.org/233843003/diff/20001/win8/win8.gyp File win8/win8.gyp (left): https://codereview.chromium.org/233843003/diff/20001/win8/win8.gyp#oldcode13 win8/win8.gyp:13: 'target_name': 'check_sdk_patch', On 2014/04/10 22:20:43, scottmg wrote: > ...
6 years, 8 months ago (2014-04-10 22:23:32 UTC) #3
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 8 months ago (2014-04-10 22:23:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/233843003/40001
6 years, 8 months ago (2014-04-10 22:25:23 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 22:53:02 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=60792
6 years, 8 months ago (2014-04-10 22:53:02 UTC) #7
scottmg
tbr robertshield
6 years, 8 months ago (2014-04-10 23:00:31 UTC) #8
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 8 months ago (2014-04-10 23:00:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/233843003/40001
6 years, 8 months ago (2014-04-10 23:01:25 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 23:41:40 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-10 23:41:40 UTC) #12
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 8 months ago (2014-04-10 23:55:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/233843003/40001
6 years, 8 months ago (2014-04-10 23:56:02 UTC) #14
robertshield
LGTM, thanks for cleaning that up, that sdk patch was horrible.
6 years, 8 months ago (2014-04-11 00:29:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/233843003/40001
6 years, 8 months ago (2014-04-11 23:49:50 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-12 03:07:51 UTC) #17
Message was sent while issue was closed. 
Change committed as 263460

Powered by Google App Engine
This is Rietveld 408576698