Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2338413003: [inspector] change implementation file extension from cpp to cc (Closed)

Created:
4 years, 3 months ago by kozy
Modified:
4 years, 3 months ago
Reviewers:
alph, dgozman
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] change implementation file extension from cpp to cc BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org TBR=machenbach@chromium.org Committed: https://crrev.com/a1612d245621003d5e16f7f880042c6f0375cf10 Cr-Commit-Position: refs/heads/master@{#39608}

Patch Set 1 #

Patch Set 2 : renamed files #

Patch Set 3 : renamed all files #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Patch Set 6 : rebased #

Patch Set 7 : rebased #

Patch Set 8 : rename string16 -> string #

Patch Set 9 : rename string16.h into string.h #

Patch Set 10 : string16 -> string-16 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -13348 lines) Patch
M src/inspector/BUILD.gn View 1 2 3 4 5 6 7 8 9 3 chunks +62 lines, -62 lines 0 comments Download
D src/inspector/DebuggerScript.js View 1 1 chunk +0 lines, -711 lines 0 comments Download
D src/inspector/InjectedScript.h View 1 2 3 4 5 6 1 chunk +0 lines, -207 lines 0 comments Download
D src/inspector/InjectedScript.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -570 lines 0 comments Download
D src/inspector/InjectedScriptNative.h View 1 2 3 1 chunk +0 lines, -47 lines 0 comments Download
D src/inspector/InjectedScriptNative.cpp View 1 2 3 1 chunk +0 lines, -89 lines 0 comments Download
D src/inspector/InjectedScriptSource.js View 1 1 chunk +0 lines, -1076 lines 0 comments Download
D src/inspector/InspectedContext.h View 1 2 3 4 5 6 1 chunk +0 lines, -64 lines 0 comments Download
D src/inspector/InspectedContext.cpp View 1 chunk +0 lines, -84 lines 0 comments Download
D src/inspector/JavaScriptCallFrame.h View 1 2 3 4 5 6 1 chunk +0 lines, -82 lines 0 comments Download
D src/inspector/JavaScriptCallFrame.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -162 lines 0 comments Download
D src/inspector/ProtocolPlatform.h View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
D src/inspector/RemoteObjectId.h View 1 1 chunk +0 lines, -58 lines 0 comments Download
D src/inspector/RemoteObjectId.cpp View 1 chunk +0 lines, -76 lines 0 comments Download
D src/inspector/ScriptBreakpoint.h View 1 1 chunk +0 lines, -52 lines 0 comments Download
D src/inspector/SearchUtil.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
D src/inspector/SearchUtil.cpp View 1 2 3 1 chunk +0 lines, -164 lines 0 comments Download
D src/inspector/String16.h View 1 2 3 1 chunk +0 lines, -132 lines 0 comments Download
D src/inspector/String16.cpp View 1 2 3 1 chunk +0 lines, -510 lines 0 comments Download
D src/inspector/StringUtil.h View 1 2 3 4 5 6 1 chunk +0 lines, -71 lines 0 comments Download
D src/inspector/StringUtil.cpp View 1 2 3 1 chunk +0 lines, -195 lines 0 comments Download
D src/inspector/V8Console.h View 1 2 3 4 5 6 1 chunk +0 lines, -119 lines 0 comments Download
D src/inspector/V8Console.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -917 lines 0 comments Download
D src/inspector/V8ConsoleAgentImpl.h View 1 2 3 4 5 6 1 chunk +0 lines, -48 lines 0 comments Download
D src/inspector/V8ConsoleAgentImpl.cpp View 1 chunk +0 lines, -79 lines 0 comments Download
D src/inspector/V8ConsoleMessage.h View 1 1 chunk +0 lines, -120 lines 0 comments Download
D src/inspector/V8ConsoleMessage.cpp View 1 2 3 1 chunk +0 lines, -473 lines 0 comments Download
D src/inspector/V8Debugger.h View 1 2 3 4 5 6 1 chunk +0 lines, -160 lines 0 comments Download
D src/inspector/V8Debugger.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -982 lines 0 comments Download
D src/inspector/V8DebuggerAgentImpl.h View 1 2 3 4 5 6 1 chunk +0 lines, -224 lines 0 comments Download
D src/inspector/V8DebuggerAgentImpl.cpp View 1 2 3 1 chunk +0 lines, -1250 lines 0 comments Download
D src/inspector/V8DebuggerScript.h View 1 2 3 4 5 6 1 chunk +0 lines, -87 lines 0 comments Download
D src/inspector/V8DebuggerScript.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -140 lines 0 comments Download
D src/inspector/V8FunctionCall.h View 1 1 chunk +0 lines, -65 lines 0 comments Download
D src/inspector/V8FunctionCall.cpp View 1 2 3 1 chunk +0 lines, -111 lines 0 comments Download
D src/inspector/V8HeapProfilerAgentImpl.h View 1 2 3 4 5 6 1 chunk +0 lines, -73 lines 0 comments Download
D src/inspector/V8HeapProfilerAgentImpl.cpp View 1 2 3 1 chunk +0 lines, -407 lines 0 comments Download
D src/inspector/V8InjectedScriptHost.h View 1 1 chunk +0 lines, -46 lines 0 comments Download
D src/inspector/V8InjectedScriptHost.cpp View 1 2 3 1 chunk +0 lines, -216 lines 0 comments Download
D src/inspector/V8InspectorImpl.h View 1 2 3 4 5 6 1 chunk +0 lines, -150 lines 0 comments Download
D src/inspector/V8InspectorImpl.cpp View 1 2 3 1 chunk +0 lines, -377 lines 0 comments Download
D src/inspector/V8InspectorSessionImpl.h View 1 2 3 4 5 6 1 chunk +0 lines, -126 lines 0 comments Download
D src/inspector/V8InspectorSessionImpl.cpp View 1 chunk +0 lines, -418 lines 0 comments Download
D src/inspector/V8InternalValueType.h View 1 1 chunk +0 lines, -23 lines 0 comments Download
D src/inspector/V8InternalValueType.cpp View 1 2 3 1 chunk +0 lines, -77 lines 0 comments Download
D src/inspector/V8ProfilerAgentImpl.h View 1 2 3 4 5 6 1 chunk +0 lines, -74 lines 0 comments Download
D src/inspector/V8ProfilerAgentImpl.cpp View 1 2 3 1 chunk +0 lines, -321 lines 0 comments Download
D src/inspector/V8Regex.h View 1 2 3 4 5 6 1 chunk +0 lines, -37 lines 0 comments Download
D src/inspector/V8Regex.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -93 lines 0 comments Download
D src/inspector/V8RuntimeAgentImpl.h View 1 2 3 4 5 6 1 chunk +0 lines, -131 lines 0 comments Download
D src/inspector/V8RuntimeAgentImpl.cpp View 1 2 3 1 chunk +0 lines, -730 lines 0 comments Download
D src/inspector/V8SchemaAgentImpl.h View 1 2 3 4 5 6 1 chunk +0 lines, -37 lines 0 comments Download
D src/inspector/V8SchemaAgentImpl.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
D src/inspector/V8StackTraceImpl.h View 1 2 3 4 5 6 1 chunk +0 lines, -99 lines 0 comments Download
D src/inspector/V8StackTraceImpl.cpp View 1 2 3 1 chunk +0 lines, -280 lines 0 comments Download
D src/inspector/V8ValueCopier.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
D src/inspector/V8ValueCopier.cpp View 1 2 3 1 chunk +0 lines, -110 lines 0 comments Download
A + src/inspector/debugger-script.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/injected-script.h View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
A + src/inspector/injected-script.cc View 1 2 3 4 5 6 1 chunk +14 lines, -14 lines 0 comments Download
A + src/inspector/injected-script-native.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/injected-script-native.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + src/inspector/injected-script-source.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/inspected-context.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
A + src/inspector/inspected-context.cc View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M src/inspector/inspector.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/inspector.gypi View 1 2 3 4 5 6 7 8 9 2 chunks +58 lines, -58 lines 0 comments Download
M src/inspector/inspector_protocol_config.json View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + src/inspector/java-script-call-frame.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + src/inspector/java-script-call-frame.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
A + src/inspector/protocol-platform.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/remote-object-id.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/remote-object-id.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + src/inspector/script-breakpoint.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
A + src/inspector/search-util.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + src/inspector/search-util.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
A + src/inspector/string-16.h View 1 2 3 4 5 6 7 8 9 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/string-16.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -3 lines 0 comments Download
A + src/inspector/string-util.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
A + src/inspector/string-util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + src/inspector/v8-console.h View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/v8-console.cc View 1 2 3 4 5 6 1 chunk +12 lines, -12 lines 0 comments Download
A + src/inspector/v8-console-agent-impl.h View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/v8-console-agent-impl.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + src/inspector/v8-console-message.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/v8-console-message.cc View 1 2 3 1 chunk +9 lines, -9 lines 0 comments Download
A + src/inspector/v8-debugger.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
A + src/inspector/v8-debugger.cc View 1 2 3 4 5 6 1 chunk +10 lines, -10 lines 0 comments Download
A + src/inspector/v8-debugger-agent-impl.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + src/inspector/v8-debugger-agent-impl.cc View 1 2 3 1 chunk +16 lines, -16 lines 0 comments Download
A + src/inspector/v8-debugger-script.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
A + src/inspector/v8-debugger-script.cc View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
A + src/inspector/v8-function-call.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
A + src/inspector/v8-function-call.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
A + src/inspector/v8-heap-profiler-agent-impl.h View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/v8-heap-profiler-agent-impl.cc View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
A + src/inspector/v8-injected-script-host.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/v8-injected-script-host.cc View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
A + src/inspector/v8-inspector-impl.h View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/v8-inspector-impl.cc View 1 2 3 1 chunk +12 lines, -13 lines 0 comments Download
A + src/inspector/v8-inspector-session-impl.h View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/v8-inspector-session-impl.cc View 1 2 1 chunk +15 lines, -15 lines 0 comments Download
A + src/inspector/v8-internal-value-type.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/v8-internal-value-type.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A + src/inspector/v8-profiler-agent-impl.h View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/v8-profiler-agent-impl.cc View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
A + src/inspector/v8-regex.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
A + src/inspector/v8-regex.cc View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
A + src/inspector/v8-runtime-agent-impl.h View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/v8-runtime-agent-impl.cc View 1 2 3 1 chunk +12 lines, -12 lines 0 comments Download
A + src/inspector/v8-schema-agent-impl.h View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/v8-schema-agent-impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + src/inspector/v8-stack-trace-impl.h View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/v8-stack-trace-impl.cc View 1 2 3 1 chunk +5 lines, -6 lines 0 comments Download
A + src/inspector/v8-value-copier.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/inspector/v8-value-copier.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/presubmit.py View 1 2 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 42 (34 generated)
kozy
please take a look!
4 years, 3 months ago (2016-09-14 22:56:07 UTC) #1
alph
It makes sense to also change CamelCase'd name to dash-based in one patch.
4 years, 3 months ago (2016-09-14 23:35:19 UTC) #2
kozy
On 2016/09/14 23:35:19, alph wrote: > It makes sense to also change CamelCase'd name to ...
4 years, 3 months ago (2016-09-15 00:51:24 UTC) #3
kozy
all files renamed, please take a look!
4 years, 3 months ago (2016-09-15 01:06:58 UTC) #4
alph
lgtm
4 years, 3 months ago (2016-09-15 03:31:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338413003/200001
4 years, 3 months ago (2016-09-21 21:52:39 UTC) #38
commit-bot: I haz the power
Committed patchset #10 (id:200001)
4 years, 3 months ago (2016-09-21 23:54:28 UTC) #40
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 23:55:25 UTC) #42
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/a1612d245621003d5e16f7f880042c6f0375cf10
Cr-Commit-Position: refs/heads/master@{#39608}

Powered by Google App Engine
This is Rietveld 408576698