Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2338413002: PPC/s390: [turbofan] Collect invocation counts and compute relative call frequencies. (Closed)

Created:
4 years, 3 months ago by JaideepBajwa
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [turbofan] Collect invocation counts and compute relative call frequencies. Port c7d7ca361dd1ba399becd54ce0d9c6e53f76c870 Original commit message: Add a notion of "invocation count" to the baseline compilers, which increment a special slot in the TypeFeedbackVector for each invocation of a given function (the optimized code doesn't currently collect this information). Use this invocation count to relativize the call counts on the call sites within the function, so that the inlining heuristic has a view of relative importance of a call site rather than some absolute numbers with unclear meaning for the current function. Also apply the call site frequency as a factor to all frequencies in the inlinee by passing this to the graph builders so that the importance of a call site in an inlinee is relative to the topmost optimized function. Note that all functions that neither have literals nor need type feedback slots will share a single invocation count cell in the canonical empty type feedback vector, so their invocation count is meaningless, but that doesn't matter since we only use the invocation count to relativize call counts within the function, which we only have if we have at least one type feedback vector (the CallIC slot). See the design document for additional details on this change: https://docs.google.com/document/d/1VoYBhpDhJC4VlqMXCKvae-8IGuheBGxy32EOgC2LnT8 R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:5267, v8:5372 LOG=N Committed: https://crrev.com/3f0c8819800baca0d994c0dffafcb528bdcc060f Cr-Commit-Position: refs/heads/master@{#39446}

Patch Set 1 #

Patch Set 2 : fixed register allocation issue #

Patch Set 3 : fixed presubmit warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
JaideepBajwa
PTAL
4 years, 3 months ago (2016-09-14 19:38:26 UTC) #1
john.yan
lgtm
4 years, 3 months ago (2016-09-14 20:11:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338413002/20001
4 years, 3 months ago (2016-09-14 20:12:32 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24094)
4 years, 3 months ago (2016-09-14 20:16:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338413002/40001
4 years, 3 months ago (2016-09-15 12:41:25 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-15 13:11:21 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 13:11:59 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3f0c8819800baca0d994c0dffafcb528bdcc060f
Cr-Commit-Position: refs/heads/master@{#39446}

Powered by Google App Engine
This is Rietveld 408576698