Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2338403002: Makes c/b/BUILD.gn and c/b/ui/BUILD.gn open to all (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes c/b/BUILD.gn and c/b/ui/BUILD.gn open to all With a comment that if you're doing something beyond add/remove of files you should get an owner. BUG=none TEST=none R=brettw@chromium.org Committed: https://crrev.com/71bc70f5bd877746ef2bf3f6a61bcae63bfa1d39 Cr-Commit-Position: refs/heads/master@{#418683}

Patch Set 1 #

Patch Set 2 : verbage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/OWNERS View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/OWNERS View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sky
4 years, 3 months ago (2016-09-14 19:32:48 UTC) #1
brettw
lgtm
4 years, 3 months ago (2016-09-14 20:12:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338403002/20001
4 years, 3 months ago (2016-09-14 20:19:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/297768)
4 years, 3 months ago (2016-09-14 20:53:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338403002/20001
4 years, 3 months ago (2016-09-14 20:55:20 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 21:34:41 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 21:36:48 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/71bc70f5bd877746ef2bf3f6a61bcae63bfa1d39
Cr-Commit-Position: refs/heads/master@{#418683}

Powered by Google App Engine
This is Rietveld 408576698