Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2367)

Unified Diff: appengine/swarming/elements/res/imp/botlist/bot-list.html

Issue 2338383002: Refactor prior to adding task-page (Closed) Base URL: git@github.com:luci/luci-py@master
Patch Set: Address nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/elements/res/imp/botlist/bot-list.html
diff --git a/appengine/swarming/elements/res/imp/botlist/bot-list.html b/appengine/swarming/elements/res/imp/botlist/bot-list.html
index 5c4072f1e376b24d5a2019e035c4d24de71f1f46..851a08fdbb2433b20b1ae611ef2d45ee5ed1137a 100644
--- a/appengine/swarming/elements/res/imp/botlist/bot-list.html
+++ b/appengine/swarming/elements/res/imp/botlist/bot-list.html
@@ -170,7 +170,7 @@
</a>
</td>
<td hidden$="[[_hide('task', _columns.*)]]">
- <a href$="[[_taskLink(bot)]]">[[_taskId(bot)]]</a>
+ <a href$="[[_taskLink(bot.task_id)]]">[[_taskId(bot)]]</a>
</td>
<template
@@ -369,11 +369,6 @@
return "";
},
- _botLink: function(id) {
- return "/newui/bot?id="+id;
- },
-
-
_androidAliasDevice: function(device) {
if (device.notReady) {
return UNAUTHENTICATED.toUpperCase();
@@ -396,14 +391,6 @@
return "";
},
- _taskLink: function(data) {
- // TODO(kjlubick): Migrate this to /newui/ when ready
- if (data && data.task_id) {
- return "/user/task/" + data.task_id;
- }
- return undefined;
- }
-
});
})();
</script>

Powered by Google App Engine
This is Rietveld 408576698