Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2338373003: Link with -Wl,--as-needed on non-optimized builds (Closed)

Created:
4 years, 3 months ago by Tom (Use chromium acct)
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Link with -Wl,--as-needed on non-optimized builds BUG=620169 R=dpranke@chromium.org Committed: https://crrev.com/ea511c32453aadb84ae6d8cb0daaad43c00092d0 Cr-Commit-Position: refs/heads/master@{#418743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M build/config/compiler/BUILD.gn View 2 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Tom (Use chromium acct)
4 years, 3 months ago (2016-09-14 19:35:50 UTC) #1
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-14 19:39:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338373003/1
4 years, 3 months ago (2016-09-15 00:27:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 01:17:52 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 01:20:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea511c32453aadb84ae6d8cb0daaad43c00092d0
Cr-Commit-Position: refs/heads/master@{#418743}

Powered by Google App Engine
This is Rietveld 408576698