Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2338353002: chromium.android: Fully swarm Marshmallow 64 bit tester (Closed)

Created:
4 years, 3 months ago by bpastene
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromium.android: Fully swarm Marshmallow 64 bit tester Will switch to gce bot if nothing regresses. BUG= Committed: https://crrev.com/7487c3a8b64ae2bc03f9aba0d5e7e85a2f4e0897 Cr-Commit-Position: refs/heads/master@{#418737}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+947 lines, -43 lines) Patch
M testing/buildbot/chromium.android.json View 2 chunks +947 lines, -43 lines 2 comments Download

Messages

Total messages: 10 (3 generated)
bpastene
ptal There is way too much boilerplate for these tests.
4 years, 3 months ago (2016-09-14 18:28:10 UTC) #2
jbudorick
lgtm and yeah, the amount of boilerplate is ... not great.
4 years, 3 months ago (2016-09-14 18:31:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338353002/1
4 years, 3 months ago (2016-09-14 23:08:53 UTC) #5
ghost stip (do not use)
nice lgtm https://codereview.chromium.org/2338353002/diff/1/testing/buildbot/chromium.android.json File testing/buildbot/chromium.android.json (left): https://codereview.chromium.org/2338353002/diff/1/testing/buildbot/chromium.android.json#oldcode3053 testing/buildbot/chromium.android.json:3053: "test": "blink_platform_unittests" dupe?
4 years, 3 months ago (2016-09-14 23:25:54 UTC) #6
bpastene
https://codereview.chromium.org/2338353002/diff/1/testing/buildbot/chromium.android.json File testing/buildbot/chromium.android.json (left): https://codereview.chromium.org/2338353002/diff/1/testing/buildbot/chromium.android.json#oldcode3053 testing/buildbot/chromium.android.json:3053: "test": "blink_platform_unittests" On 2016/09/14 23:25:53, stip wrote: > dupe? ...
4 years, 3 months ago (2016-09-14 23:37:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 01:11:12 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 01:16:01 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7487c3a8b64ae2bc03f9aba0d5e7e85a2f4e0897
Cr-Commit-Position: refs/heads/master@{#418737}

Powered by Google App Engine
This is Rietveld 408576698