|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by charliea (OOO until 10-5) Modified:
4 years, 2 months ago Reviewers:
nednguyen CC:
chromium-reviews, telemetry-reviews_chromium.org, petrcermak, perezju, kouhei (in TOK), Kunihiko Sakamoto Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[system health] Compute power and clock sync latency metrics
I added the "common system health benchmark" (i.e. non-memory
benchmark), but forgot to have it compute any metrics. This fixes that.
I also removed the old system health loading stories from the "battor"
benchmark set. Eventually, I imagine that this set will go away
completely as BattOr metrics are computed in other benchmarks.
BUG=637158
NOTRY=true
Committed: https://crrev.com/7c742ced7137db2e6785822d2a2f8299178b3537
Cr-Commit-Position: refs/heads/master@{#424536}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : Synced to head #
Messages
Total messages: 43 (23 generated)
Description was changed from ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. BUG=637158 ========== to ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. BUG=637158 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. BUG=637158 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. I also removed the old system health loading stories from the "battor" benchmark set. Eventually, I imagine that this set will go away completely as BattOr metrics are computed in other benchmarks. BUG=637158 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
charliea@chromium.org changed reviewers: + nednguyen@google.com
lgtm
Description was changed from ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. I also removed the old system health loading stories from the "battor" benchmark set. Eventually, I imagine that this set will go away completely as BattOr metrics are computed in other benchmarks. BUG=637158 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. I also removed the old system health loading stories from the "battor" benchmark set. Eventually, I imagine that this set will go away completely as BattOr metrics are computed in other benchmarks. BUG=637158 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
On 2016/09/14 18:41:30, nednguyen wrote: > lgtm +Kouhei, Ksakamoto: later once loading_metric support multiple renderer process, we can also enable loadingMetric for this benchmark
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
On 2016/09/16 02:33:12, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build > URL) The mac failure are blocked on https://codereview.chromium.org/2342303002/
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_cq/bu...)
Description was changed from ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. I also removed the old system health loading stories from the "battor" benchmark set. Eventually, I imagine that this set will go away completely as BattOr metrics are computed in other benchmarks. BUG=637158 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. I also removed the old system health loading stories from the "battor" benchmark set. Eventually, I imagine that this set will go away completely as BattOr metrics are computed in other benchmarks. BUG=637158 ==========
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. I also removed the old system health loading stories from the "battor" benchmark set. Eventually, I imagine that this set will go away completely as BattOr metrics are computed in other benchmarks. BUG=637158 ========== to ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. I also removed the old system health loading stories from the "battor" benchmark set. Eventually, I imagine that this set will go away completely as BattOr metrics are computed in other benchmarks. BUG=637158 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by charliea@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2338343002/#ps40001 (title: "Synced to head")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
Description was changed from ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. I also removed the old system health loading stories from the "battor" benchmark set. Eventually, I imagine that this set will go away completely as BattOr metrics are computed in other benchmarks. BUG=637158 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. I also removed the old system health loading stories from the "battor" benchmark set. Eventually, I imagine that this set will go away completely as BattOr metrics are computed in other benchmarks. BUG=637158 NOTRY=true ==========
Have to add NOTRY=true because several builders on the CQ are flaky
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. I also removed the old system health loading stories from the "battor" benchmark set. Eventually, I imagine that this set will go away completely as BattOr metrics are computed in other benchmarks. BUG=637158 NOTRY=true ========== to ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. I also removed the old system health loading stories from the "battor" benchmark set. Eventually, I imagine that this set will go away completely as BattOr metrics are computed in other benchmarks. BUG=637158 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. I also removed the old system health loading stories from the "battor" benchmark set. Eventually, I imagine that this set will go away completely as BattOr metrics are computed in other benchmarks. BUG=637158 NOTRY=true ========== to ========== [system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. I also removed the old system health loading stories from the "battor" benchmark set. Eventually, I imagine that this set will go away completely as BattOr metrics are computed in other benchmarks. BUG=637158 NOTRY=true Committed: https://crrev.com/7c742ced7137db2e6785822d2a2f8299178b3537 Cr-Commit-Position: refs/heads/master@{#424536} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/7c742ced7137db2e6785822d2a2f8299178b3537 Cr-Commit-Position: refs/heads/master@{#424536} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
