Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2338343002: [system health] Compute power and clock sync latency metrics (Closed)

Created:
4 years, 3 months ago by charliea (OOO until 10-5)
Modified:
4 years, 2 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, petrcermak, perezju, kouhei (in TOK), Kunihiko Sakamoto
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[system health] Compute power and clock sync latency metrics I added the "common system health benchmark" (i.e. non-memory benchmark), but forgot to have it compute any metrics. This fixes that. I also removed the old system health loading stories from the "battor" benchmark set. Eventually, I imagine that this set will go away completely as BattOr metrics are computed in other benchmarks. BUG=637158 NOTRY=true Committed: https://crrev.com/7c742ced7137db2e6785822d2a2f8299178b3537 Cr-Commit-Position: refs/heads/master@{#424536}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Synced to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -41 lines) Patch
M tools/perf/benchmarks/battor.py View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
M tools/perf/benchmarks/system_health.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 43 (23 generated)
charliea (OOO until 10-5)
4 years, 3 months ago (2016-09-14 18:13:35 UTC) #4
nednguyen
lgtm
4 years, 3 months ago (2016-09-14 18:41:30 UTC) #5
nednguyen
On 2016/09/14 18:41:30, nednguyen wrote: > lgtm +Kouhei, Ksakamoto: later once loading_metric support multiple renderer ...
4 years, 3 months ago (2016-09-15 00:39:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338343002/20001
4 years, 3 months ago (2016-09-15 20:23:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-16 02:33:12 UTC) #11
nednguyen
On 2016/09/16 02:33:12, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-16 11:46:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338343002/20001
4 years, 3 months ago (2016-09-21 14:33:08 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_cq/builds/348)
4 years, 3 months ago (2016-09-21 17:12:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338343002/20001
4 years, 2 months ago (2016-09-28 14:01:52 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/285732) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 2 months ago (2016-09-28 14:09:21 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338343002/20001
4 years, 2 months ago (2016-09-28 14:11:57 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/136170)
4 years, 2 months ago (2016-09-28 14:14:17 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338343002/20001
4 years, 2 months ago (2016-09-28 14:15:28 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/285744) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 2 months ago (2016-09-28 14:17:51 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338343002/40001
4 years, 2 months ago (2016-10-11 13:49:20 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/84037)
4 years, 2 months ago (2016-10-11 14:01:27 UTC) #35
charliea (OOO until 10-5)
Have to add NOTRY=true because several builders on the CQ are flaky
4 years, 2 months ago (2016-10-11 20:33:17 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338343002/40001
4 years, 2 months ago (2016-10-11 20:33:49 UTC) #39
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-11 20:41:54 UTC) #41
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 20:43:50 UTC) #43
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7c742ced7137db2e6785822d2a2f8299178b3537
Cr-Commit-Position: refs/heads/master@{#424536}

Powered by Google App Engine
This is Rietveld 408576698