Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 233833002: Add bench_playback, for quick profiling of SKR playback. (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 8 months ago
Reviewers:
f(malita), mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add bench_playback, for quick profiling of SKR playback. It is not completely fair to compare --skr and --noskr numbers. SKR looks unfairly good because some optimizations are baked into our SKPs at record time. But, at least, by using a kWriteOnly_Mode SkRecorder, we prevent SkPicturePlayback from compounding that unfairness. SkRecordDraw must handle its own playback-time optimizations (quickrejects) on its own. This code should look suspiciously similar to bench_record. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14151

Patch Set 1 #

Patch Set 2 : delete redundant clear #

Patch Set 3 : share a scratch bitmap #

Patch Set 4 : move in #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -0 lines) Patch
M gyp/tools.gyp View 2 chunks +19 lines, -0 lines 0 comments Download
A tools/bench_playback.cpp View 1 2 3 1 chunk +93 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (0 generated)
mtklein
6 years, 8 months ago (2014-04-10 22:06:37 UTC) #1
f(malita)
lgtm https://codereview.chromium.org/233833002/diff/60001/tools/bench_playback.cpp File tools/bench_playback.cpp (right): https://codereview.chromium.org/233833002/diff/60001/tools/bench_playback.cpp#newcode49 tools/bench_playback.cpp:49: int tool_main(int argc, char** argv); Is this needed?
6 years, 8 months ago (2014-04-10 23:27:37 UTC) #2
mtklein
On 2014/04/10 23:27:37, Florin Malita wrote: > lgtm > > https://codereview.chromium.org/233833002/diff/60001/tools/bench_playback.cpp > File tools/bench_playback.cpp (right): ...
6 years, 8 months ago (2014-04-11 00:31:29 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-11 00:31:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/233833002/60001
6 years, 8 months ago (2014-04-11 00:31:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 00:31:41 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-11 00:31:42 UTC) #7
mtklein
lgtm
6 years, 8 months ago (2014-04-11 00:31:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/233833002/60001
6 years, 8 months ago (2014-04-11 00:32:00 UTC) #9
mtklein
https://codereview.chromium.org/233833002/diff/60001/tools/bench_playback.cpp File tools/bench_playback.cpp (right): https://codereview.chromium.org/233833002/diff/60001/tools/bench_playback.cpp#newcode49 tools/bench_playback.cpp:49: int tool_main(int argc, char** argv); On 2014/04/10 23:27:37, Florin ...
6 years, 8 months ago (2014-04-11 01:22:35 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 15:53:42 UTC) #11
Message was sent while issue was closed.
Change committed as 14151

Powered by Google App Engine
This is Rietveld 408576698