Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: pkg/dev_compiler/lib/src/compiler/code_generator.dart

Issue 2338323004: Cleanup. Fix new analyzer errors due to recent strong mode changes. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/dev_compiler/pubspec.lock » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/code_generator.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/code_generator.dart b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
index 783e7da39cf254546081c1448d3c88dbd217a656..fdd021ed2b747145234b0a4d493858704276d737 100644
--- a/pkg/dev_compiler/lib/src/compiler/code_generator.dart
+++ b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
@@ -2503,8 +2503,10 @@ class CodeGenerator extends GeneralizingAstVisitor
var typeFormals = _emitTypeFormals(type.typeFormals);
var returnType = emitTypeRef(type.returnType);
if (type.typeFormals.isNotEmpty) {
- code = new JS.Block(
- [new JS.Block(_typeTable.discharge(type.typeFormals)), code]);
+ code = new JS.Block(<JS.Statement>[
Jennifer Messerly 2016/09/15 17:54:04 btw this cast could probably go on "_visit(body) a
+ new JS.Block(_typeTable.discharge(type.typeFormals)),
+ code
+ ]);
}
return new JS.Fun(formals, code,
typeParams: typeFormals, returnType: returnType);
@@ -4501,7 +4503,8 @@ class CodeGenerator extends GeneralizingAstVisitor
var param =
_createTemporary('_', nodeTarget.staticType, nullable: false);
var baseNode = _stripNullAwareOp(node, param);
- tail.add(new JS.ArrowFun([_visit(param)], _visit(baseNode)));
+ tail.add(
+ new JS.ArrowFun(<JS.Parameter>[_visit(param)], _visit(baseNode)));
node = nodeTarget;
} else {
break;
« no previous file with comments | « no previous file | pkg/dev_compiler/pubspec.lock » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698