Issue 2338323004: Cleanup. Fix new analyzer errors due to recent strong mode changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2338323004: Cleanup. Fix new analyzer errors due to recent strong mode changes. (Closed)

Created:
4 years, 3 months ago by Jacob

Modified:
4 years, 3 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Cleanup. Fix new analyzer errors due to recent strong mode changes. BUG= Committed: https://github.com/dart-lang/dev_compiler/commit/7341e3d34c1809e48b35c5a9727c570f76bbbea0

Patch Set 1 #

Total comments: 1

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	pkg/dev_compiler/lib/src/compiler/code_generator.dart	View		2 chunks	+6 lines, -3 lines	1 comment	Download
	M	pkg/dev_compiler/pubspec.lock	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jacob

Committed patchset #1 (id:1) manually as 7341e3d34c1809e48b35c5a9727c570f76bbbea0 (presubmit successful).

4 years, 3 months ago (2016-09-15 17:45:15 UTC) #4

Jennifer Messerly

4 years, 3 months ago (2016-09-15 17:54:05 UTC) #5

Message was sent while issue was closed.

lgtm, thank you!

https://codereview.chromium.org/2338323004/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2338323004/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:2506: code = new
JS.Block(<JS.Statement>[
btw this cast could probably go on "_visit(body) as JS.Statement", I'm guessing
that's where dynamic is coming from.

But this works too. It'll end up as 1 cast either way :)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages