Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2338323002: quad and conic do not intersect (Closed)

Created:
4 years, 3 months ago by caryclark
Modified:
4 years, 3 months ago
Reviewers:
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

quad and conic do not intersect If a quad a conic intersect only where the end of one is contained by the convex hull of the other, and the curve contained by the hull is nearly a straight line, treating it as a line may move the end point to the other side of the curve. Detect this by checking to see if the end point is in the hull, and if so, continue to subdivide the curve rather than treating it as a line. This fixes several existing tests that were disabled earlier this year. A typo in SkDCurve::nearPoint() prevented detecting when the end of a line was nearly touching a curve. Also fixed concidence a bit to get the second half of tiger further along. All existing tests, including extended testing in Release and the first half of tiger, work. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2338323002 Committed: https://skia.googlesource.com/skia/+/e839e78443e48d4ccad89059b4bc4b3d894fcfdd

Patch Set 1 #

Patch Set 2 : checkpoint; fixes old broken tests #

Patch Set 3 : turn off under development #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -39 lines) Patch
M src/pathops/SkDConicLineIntersection.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 1 2 chunks +5 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsCurve.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsQuad.cpp View 1 2 chunks +30 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsTSect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/PathOpsFuzz763Test.cpp View 1 3 chunks +3 lines, -5 lines 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 2 4 chunks +16 lines, -5 lines 0 comments Download
M tools/pathops_sorter.htm View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M tools/pathops_visualizer.htm View 1 1 chunk +81 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338323002/40001
4 years, 3 months ago (2016-09-15 14:30:41 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 14:48:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e839e78443e48d4ccad89059b4bc4b3d894fcfdd

Powered by Google App Engine
This is Rietveld 408576698