Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2338303002: Remove FFI_ from CPDFSDK_Environment method names (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove FFI_ from CPDFSDK_Environment method names The prefix doesn't add anything when used in CPDFSDK_Environment, remove. Committed: https://pdfium.googlesource.com/pdfium/+/1f2489023f2b808c41071d992abceb646ade8e1b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -313 lines) Patch
M fpdfsdk/cfx_systemhandler.cpp View 4 chunks +9 lines, -10 lines 0 comments Download
M fpdfsdk/cpdfsdk_annothandlermgr.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_document.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/cpdfsdk_interform.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/formfiller/cffl_combobox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_iformfiller.cpp View 13 chunks +26 lines, -26 lines 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp View 15 chunks +21 lines, -23 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_app.cpp View 4 chunks +8 lines, -27 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_util.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfxfa/include/fpdfxfa_app.h View 1 chunk +0 lines, -3 lines 0 comments Download
M fpdfsdk/fsdk_actionhandler.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/cpdfsdk_environment.h View 4 chunks +156 lines, -172 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/Field.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/app.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M public/fpdf_formfill.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/fxfa/include/fxfa.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/cscript_hostpseudomodel.cpp View 1 2 chunks +4 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-09-14 16:12:37 UTC) #2
Wei Li
lgtm otherwise https://codereview.chromium.org/2338303002/diff/1/xfa/fxfa/parser/cscript_hostpseudomodel.cpp File xfa/fxfa/parser/cscript_hostpseudomodel.cpp (right): https://codereview.chromium.org/2338303002/diff/1/xfa/fxfa/parser/cscript_hostpseudomodel.cpp#newcode332 xfa/fxfa/parser/cscript_hostpseudomodel.cpp:332: if (!pNotify) Is this still useful? Looks ...
4 years, 3 months ago (2016-09-14 16:56:24 UTC) #7
dsinclair
https://codereview.chromium.org/2338303002/diff/1/xfa/fxfa/parser/cscript_hostpseudomodel.cpp File xfa/fxfa/parser/cscript_hostpseudomodel.cpp (right): https://codereview.chromium.org/2338303002/diff/1/xfa/fxfa/parser/cscript_hostpseudomodel.cpp#newcode332 xfa/fxfa/parser/cscript_hostpseudomodel.cpp:332: if (!pNotify) On 2016/09/14 16:56:24, Wei Li wrote: > ...
4 years, 3 months ago (2016-09-14 17:23:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338303002/20001
4 years, 3 months ago (2016-09-14 17:23:40 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 17:38:21 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/1f2489023f2b808c41071d992abceb646ade...

Powered by Google App Engine
This is Rietveld 408576698