Site Settings Desktop: Implement Cookie Search.

Site Settings Desktop: Implement Cookie Search.

BUG=634039, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/12af1f692af925903b750459b9545cc75c839a85
Cr-Commit-Position: refs/heads/master@{#419142}

[Finnur, 2016-09-14 15:47:25]

Description was changed from

==========
Site Settings Desktop: Implement Cookie Search.

BUG=646309, 614277
==========

to

==========
Site Settings Desktop: Implement Cookie Search.

BUG=646309, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Finnur, 2016-09-14 15:53:03]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[Finnur, 2016-09-14 15:53:08]

finnur@chromium.org changed reviewers:
+ dschuyler@chromium.org

[commit-bot: I haz the power, 2016-09-14 15:53:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 17:09:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 17:09:44]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-09-14 19:09:57]

On 2016/09/14 15:53:09, Finnur wrote:

Thanks for doing this. Sorry, but can we use settings_subpage_search.html here?
It's important that the search features in each settings section is consistent
and a good way to do that is to use the same control in each place. Here's a 
link to the settings_subpage_search.html.

https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settin...

[Finnur, 2016-09-15 13:15:34]

The CQ bit was checked by finnur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 13:15:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Finnur, 2016-09-15 13:16:00]

Hey, neat!

Look OK now?

[Finnur, 2016-09-15 13:27:13]

Description was changed from

==========
Site Settings Desktop: Implement Cookie Search.

BUG=646309, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: Implement Cookie Search.

BUG=634039, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-15 14:54:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 14:54:44]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-09-15 20:40:28]

lgtm

https://codereview.chromium.org/2338283002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_data.html (right):

https://codereview.chromium.org/2338283002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data.html:2: <link
rel="import" href="chrome://resources/cr_elements/icons.html">
nit: is this still needed?

[Finnur, 2016-09-16 10:14:14]

https://codereview.chromium.org/2338283002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_data.html (right):

https://codereview.chromium.org/2338283002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data.html:2: <link
rel="import" href="chrome://resources/cr_elements/icons.html">
Nope, thanks!

[Finnur, 2016-09-16 10:17:33]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2016-09-16 10:17:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2338283002/#ps60001
(title: "Address feedback")

[commit-bot: I haz the power, 2016-09-16 10:17:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 11:19:45]

Description was changed from

==========
Site Settings Desktop: Implement Cookie Search.

BUG=634039, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: Implement Cookie Search.

BUG=634039, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-16 11:19:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-16 11:21:13]

Description was changed from

==========
Site Settings Desktop: Implement Cookie Search.

BUG=634039, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Site Settings Desktop: Implement Cookie Search.

BUG=634039, 614277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/12af1f692af925903b750459b9545cc75c839a85
Cr-Commit-Position: refs/heads/master@{#419142}
==========

[commit-bot: I haz the power, 2016-09-16 11:21:14]

Patchset 4 (id:??) landed as
https://crrev.com/12af1f692af925903b750459b9545cc75c839a85
Cr-Commit-Position: refs/heads/master@{#419142}