Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2338273007: async/await: Don't trigger uncaught rejection handlers on throwaway Promises (Closed)

Created:
4 years, 3 months ago by Dan Ehrenberg
Modified:
4 years, 3 months ago
Reviewers:
domenic, adamk
CC:
v8-reviews_googlegroups.com, caitp
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

async/await: Don't trigger uncaught rejection handlers on throwaway Promises This patch implements a bug fix to the async/await specification described at https://github.com/tc39/ecma262/pull/692#issuecomment-247488411 Namely, the intermediate values of Promises may be rejected, and they do not have .then called on them anymore (now that the memory leak is fixed), but they do not correspond do unhandled rejections. This change has been tested manually with integration with Blink; once it is checked in and rolled, then further tests can be added on the Blink side for the uncaught rejection handler and async/await. BUG=v8:4483 Committed: https://crrev.com/61a6b6f236079927a0e9640742fe4b0c282a9d09 Cr-Commit-Position: refs/heads/master@{#39480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/js/harmony-async-await.js View 2 chunks +7 lines, -0 lines 0 comments Download
M src/js/prologue.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Dan Ehrenberg
4 years, 3 months ago (2016-09-16 19:06:45 UTC) #4
domenic
Non-reviewer LGTM. Note that there's the potential for further future optimizations/fixes by getting rid of ...
4 years, 3 months ago (2016-09-16 19:12:25 UTC) #5
adamk
lgtm
4 years, 3 months ago (2016-09-16 20:13:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338273007/1
4 years, 3 months ago (2016-09-16 20:20:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 20:23:09 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 20:24:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61a6b6f236079927a0e9640742fe4b0c282a9d09
Cr-Commit-Position: refs/heads/master@{#39480}

Powered by Google App Engine
This is Rietveld 408576698