appengine/findit/model/crash/crash_config.py - Issue 2338273006: [Findit] Factoring out the components, so they can classify themselves

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/model/crash/crash_config.py

Issue 2338273006: [Findit] Factoring out the components, so they can classify themselves (Closed)

Patch Set: rebasing to remove dependency on crrev.com/2344443005 Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/model/crash/crash_config.py

diff --git a/appengine/findit/model/crash/crash_config.py b/appengine/findit/model/crash/crash_config.py

index 344a705b50b5cfefce94e506cc8ad4ea61cbc5f1..e80f6c8213ecd7b782a02070c95d5aeb4952c45d 100644

--- a/appengine/findit/model/crash/crash_config.py

+++ b/appengine/findit/model/crash/crash_config.py

@@ -111,6 +111,7 @@ class CrashConfig(VersionedConfig):

compiled_path_function_component = []

for path, function, component in self.component_classifier[

'path_function_component']:

+ # TODO(wrengr): build Component objects here, rather than later.

compiled_path_function_component.append(

[re.compile(path),

re.compile(function) if function else None,

« no previous file with comments | « appengine/findit/crash/test/component_classifier_test.py ('k') | no next file » | no next file with comments »