[Findit] Factoring out the components, so they can classify themselves

appengine/findit/crash/findit_for_chromecrash.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Process crashes from Chrome crash server and find culprits for them."""
 
 import logging
 
 from common import chromium_deps
 from crash import detect_regression_range
 from crash import findit_for_crash
 from crash.fracas_parser import FracasParser
 from crash.project_classifier import ProjectClassifier
+from crash.component import Component
 from crash.component_classifier import ComponentClassifier
 from model.crash.crash_config import CrashConfig
 
 # TODO(katesonia): Remove the default value after adding validity check to
 # config.
 _DEFAULT_TOP_N = 7
 
 
 def FindCulpritForChromeCrash(signature, platform,
                               stack_trace, crashed_version, historic_metadata):
@@ skipping 89 matching lines @@
         last_good_version, first_bad_version, platform)
 
   crash_config = CrashConfig.Get()
   culprit_results = findit_for_crash.FindItForCrash(
       stacktrace, regression_deps_rolls, crash_deps, crash_config.fracas.get(
           'top_n', _DEFAULT_TOP_N))
 
   crash_stack = stacktrace.crash_stack
   suspected_project = ProjectClassifier().Classify(
       culprit_results, crash_stack)
-  suspected_components = ComponentClassifier().Classify(
-      culprit_results, crash_stack)
+
+  component_classifier_config = CrashConfig.Get().compiled_component_classifier
+  suspected_components = ComponentClassifier(
+      # TODO(wrengr): have the config return Component objects directly,
+      # rather than needing to convert them here.
+      [Component(component_name, path_regex, function_regex)
+          for path_regex, function_regex, component_name
+          in component_classifier_config['path_function_component']],
+      component_classifier_config['top_n']
+    ).Classify(culprit_results, crash_stack)
 
   # TODO(http://crbug.com/644411): the caller should convert things to
   # JSON, not us.
   culprit_results_list = [result.ToDict() for result in culprit_results]
 
   return (
       {
           'found': (bool(suspected_project) or bool(suspected_components) or
                     bool(culprit_results_list)),
           'regression_range': regression_versions,
           'suspected_project': suspected_project,
           'suspected_components': suspected_components,
           'suspected_cls': culprit_results_list,
       },
       {
           'found_suspects': bool(culprit_results_list),
           'has_regression_range': bool(regression_versions),
           'solution': 'core_algorithm',
       }
   )