[Extensions] Make feature-related singletons leaky

[Extensions] Make feature-related singletons leaky

It seems that feature-related singleton classes can be potentially
accessed during shutdown, which will crash. Make these classes
leaky, which is now the preference anyway.

BUG=646275
Committed: https://crrev.com/61bf613582b9102ed0ac76efbaa32b432d9fc7a8
Cr-Commit-Position: refs/heads/master@{#418979}

[Devlin, 2016-09-15 18:39:40]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 18:40:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 19:21:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 19:22:00]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-09-15 20:36:44]

Description was changed from

==========
Leak
BUG=
==========

to

==========
[Extensions] Make feature-related singletons leaky

It seems that feature-related singleton classes can be potentially
accessed during shutdown, which will crash. Make these classes
leaky, which is now the preference anyway.

BUG=646275
==========

[Devlin, 2016-09-15 20:37:18]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-09-15 20:37:19]

lazyboy@, can you take a look?

[lazyboy, 2016-09-15 21:13:34]

lgtm.

[Devlin, 2016-09-15 21:14:59]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-09-15 21:15:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 21:23:31]

Description was changed from

==========
[Extensions] Make feature-related singletons leaky

It seems that feature-related singleton classes can be potentially
accessed during shutdown, which will crash. Make these classes
leaky, which is now the preference anyway.

BUG=646275
==========

to

==========
[Extensions] Make feature-related singletons leaky

It seems that feature-related singleton classes can be potentially
accessed during shutdown, which will crash. Make these classes
leaky, which is now the preference anyway.

BUG=646275
==========

[commit-bot: I haz the power, 2016-09-15 21:23:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-15 21:25:42]

Description was changed from

==========
[Extensions] Make feature-related singletons leaky

It seems that feature-related singleton classes can be potentially
accessed during shutdown, which will crash. Make these classes
leaky, which is now the preference anyway.

BUG=646275
==========

to

==========
[Extensions] Make feature-related singletons leaky

It seems that feature-related singleton classes can be potentially
accessed during shutdown, which will crash. Make these classes
leaky, which is now the preference anyway.

BUG=646275

Committed: https://crrev.com/61bf613582b9102ed0ac76efbaa32b432d9fc7a8
Cr-Commit-Position: refs/heads/master@{#418979}
==========

[commit-bot: I haz the power, 2016-09-15 21:25:42]

Patchset 1 (id:??) landed as
https://crrev.com/61bf613582b9102ed0ac76efbaa32b432d9fc7a8
Cr-Commit-Position: refs/heads/master@{#418979}