Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issue 2338263004: [turbofan] Int32Add/Sub/MulWithOverflow also zero extend to 64bit. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Int32Add/Sub/MulWithOverflow also zero extend to 64bit. R=jarin@chromium.org Committed: https://crrev.com/e16f83c77c4775274f0f6148338176f6b7d687da Cr-Commit-Position: refs/heads/master@{#39437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +29 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-15 05:34:49 UTC) #1
Jarin
lgtm
4 years, 3 months ago (2016-09-15 05:40:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338263004/1
4 years, 3 months ago (2016-09-15 05:40:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 06:00:14 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 06:01:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e16f83c77c4775274f0f6148338176f6b7d687da
Cr-Commit-Position: refs/heads/master@{#39437}

Powered by Google App Engine
This is Rietveld 408576698