Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 233823003: Defer input stream start around suspend and resume. (Closed)

Created:
6 years, 8 months ago by DaleCurtis
Modified:
6 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Defer input stream start around suspend and resume. As with output streams on OSX, we should defer input stream starts around suspend and resume. UMA statistic rates for M33 -> M34 show us going from 0.54% to 0.30% failures! Lets see if we can go even further. BUG=160920, 361999 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264073

Patch Set 1 #

Patch Set 2 : Fix includes. #

Patch Set 3 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -26 lines) Patch
M media/audio/audio_input_unittest.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M media/audio/mac/audio_auhal_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_input_mac.h View 1 4 chunks +6 lines, -3 lines 0 comments Download
M media/audio/mac/audio_input_mac.cc View 1 3 chunks +19 lines, -3 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.h View 2 chunks +4 lines, -1 line 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac_unittest.cc View 1 2 8 chunks +22 lines, -10 lines 0 comments Download
M media/audio/mac/audio_manager_mac.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
DaleCurtis
6 years, 8 months ago (2014-04-10 21:36:42 UTC) #1
no longer working on chromium
On 2014/04/10 21:36:42, DaleCurtis wrote: lgtm, thanks for wiring it up.
6 years, 8 months ago (2014-04-11 11:47:28 UTC) #2
no longer working on chromium
On 2014/04/11 11:47:28, xians1 wrote: > On 2014/04/10 21:36:42, DaleCurtis wrote: > > lgtm, thanks ...
6 years, 8 months ago (2014-04-15 13:21:18 UTC) #3
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 8 months ago (2014-04-15 18:01:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/233823003/40001
6 years, 8 months ago (2014-04-15 18:02:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/233823003/40001
6 years, 8 months ago (2014-04-16 01:21:14 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 02:35:59 UTC) #7
Message was sent while issue was closed.
Change committed as 264073

Powered by Google App Engine
This is Rietveld 408576698