Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 2338213008: Revert of SkPDF: Implement /ActualText to make text extraction correct. (Closed)

Created:
4 years, 3 months ago by hal.canary
Modified:
4 years, 3 months ago
CC:
reviews_skia.org, RikC
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkPDF: Implement /ActualText to make text extraction correct. (patchset #11 id:220001 of https://codereview.chromium.org/2322403002/ ) Reason for revert: MSAN, ASAN errors Original issue's description: > SkPDF: Implement /ActualText to make text extraction correct. > > For old API: no change. > > For new API: LTR text is perfectly extracted, RTL needs better testing. > > BUG=skia:5434 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2322403002 > > Committed: https://skia.googlesource.com/skia/+/dbd16345a5b2b824f2696af791bb0f01304cf549 TBR=tomhudson@google.com,bungeman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5434 Committed: https://skia.googlesource.com/skia/+/3b294d5ba96b68ae1cbe59cfea29b112959cca09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -309 lines) Patch
M src/pdf/SkPDFDevice.cpp View 8 chunks +55 lines, -297 lines 0 comments Download
M src/pdf/SkPDFMakeToUnicodeCmap.cpp View 3 chunks +12 lines, -2 lines 0 comments Download
M src/pdf/SkPDFUtils.h View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
hal.canary
Created Revert of SkPDF: Implement /ActualText to make text extraction correct.
4 years, 3 months ago (2016-09-16 20:20:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338213008/1
4 years, 3 months ago (2016-09-16 20:21:05 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 20:21:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3b294d5ba96b68ae1cbe59cfea29b112959cca09

Powered by Google App Engine
This is Rietveld 408576698