chrome/browser/profiles/profile_downloader.cc - Issue 23382008: Making OAuth2TokenService multi-login aware, updating callers, minor fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_downloader.cc

Issue 23382008: Making OAuth2TokenService multi-login aware, updating callers, minor fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updates to AndroidPO2TS and removing the DCHECK(signin_manager) from GetPrimaryAccountId Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/policy/cloud/cloud_policy_client_registration_helper.cc ('K') | « chrome/browser/policy/cloud/user_policy_signin_service.cc ('k') | chrome/browser/signin/android_profile_oauth2_token_service.h » ('j') | chrome/browser/signin/android_profile_oauth2_token_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_downloader.cc

diff --git a/chrome/browser/profiles/profile_downloader.cc b/chrome/browser/profiles/profile_downloader.cc

index 08da574b808479a3afea1600ac7f2f5c87cda1da..79365c49fe383cf388d9ebbac731f3dc45bda7a7 100644

--- a/chrome/browser/profiles/profile_downloader.cc

+++ b/chrome/browser/profiles/profile_downloader.cc

@@ -209,7 +209,8 @@ void ProfileDownloader::Start() {

return;

}

- if (service->RefreshTokenIsAvailable()) {

+ if (service->RefreshTokenIsAvailable(

+ service->GetPrimaryAccountId())) {

StartFetchingOAuth2AccessToken();

} else {

service->AddObserver(this);

@@ -252,9 +253,10 @@ void ProfileDownloader::StartFetchingOAuth2AccessToken() {

Profile* profile = delegate_->GetBrowserProfile();

OAuth2TokenService::ScopeSet scopes;

scopes.insert(kAPIScope);

- oauth2_access_token_request_ =

- ProfileOAuth2TokenServiceFactory::GetForProfile(profile)

- ->StartRequestWithContext(profile->GetRequestContext(), scopes, this);

+ ProfileOAuth2TokenService* token_service =

+ ProfileOAuth2TokenServiceFactory::GetForProfile(profile);

+ oauth2_access_token_request_ = token_service->StartRequest(

+ token_service->GetPrimaryAccountId(), scopes, this);

}

ProfileDownloader::~ProfileDownloader() {}