Making OAuth2TokenService multi-login aware, updating callers, minor fixes

chrome/browser/local_discovery/privet_confirm_api_flow_unittest.cc

Index: chrome/browser/local_discovery/privet_confirm_api_flow_unittest.cc
diff --git a/chrome/browser/local_discovery/privet_confirm_api_flow_unittest.cc b/chrome/browser/local_discovery/privet_confirm_api_flow_unittest.cc
index 3ab9da0c42c1159f9da04c7eecbc26963008aaba..96560da594621e281c94f574970531a1deb640ef 100644
--- a/chrome/browser/local_discovery/privet_confirm_api_flow_unittest.cc
+++ b/chrome/browser/local_discovery/privet_confirm_api_flow_unittest.cc
@@ -5,6 +5,7 @@
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "chrome/browser/local_discovery/privet_confirm_api_flow.h"
+#include "chrome/browser/signin/fake_profile_oauth2_token_service.h"
 #include "content/public/test/test_browser_thread.h"
 #include "google_apis/gaia/google_service_auth_error.h"
 #include "net/base/host_port_pair.h"
@@ -39,7 +40,7 @@ class TestOAuth2TokenService : public OAuth2TokenService {
       : request_context_(request_context) {
   }
  protected:
-  virtual std::string GetRefreshToken() OVERRIDE {
+  virtual std::string GetRefreshToken(const std::string& account_id) OVERRIDE {
     return "SampleToken";
   }
 
@@ -87,6 +88,7 @@ class PrivetConfirmApiFlowTest : public testing::Test {
 TEST_F(PrivetConfirmApiFlowTest, SuccessOAuth2) {
   PrivetConfirmApiCallFlow confirm_flow(request_context_.get(),
                                         &token_service_,
+                                        std::string(),

[Andrew T Wilson (Slow), 2013/09/03 14:04:24]

This is fine - I just wonder if perhaps we want to prevent ever passing in an
empty account ID to OAuth2TokenService, so we should codify that with a DCHECK()
and make tests pass in a non-empty test acct ID. Your call - just wanted to
suggest it.

[fgorski, 2013/09/03 20:50:40]

Done. I agree with you. Roger mentioned a potential DCHECK earlier I just never
got down to revisiting all of the calls. Given that GetRefreshToken is simply
returning tokens here, I am using a dummy account_id.

                                         GURL("http://SoMeUrL.com"),
                                         callback_.callback());
 
@@ -149,6 +151,7 @@ TEST_F(PrivetConfirmApiFlowTest, SuccessCookies) {
 TEST_F(PrivetConfirmApiFlowTest, BadToken) {
   PrivetConfirmApiCallFlow confirm_flow(request_context_.get(),
                                         &token_service_,
+                                        std::string(),
                                         GURL("http://SoMeUrL.com"),
                                         callback_.callback());
 
@@ -163,6 +166,7 @@ TEST_F(PrivetConfirmApiFlowTest, BadToken) {
 TEST_F(PrivetConfirmApiFlowTest, ServerFailure) {
   PrivetConfirmApiCallFlow confirm_flow(request_context_.get(),
                                         &token_service_,
+                                        std::string(),
                                         GURL("http://SoMeUrL.com"),
                                         callback_.callback());
 
@@ -187,6 +191,7 @@ TEST_F(PrivetConfirmApiFlowTest, ServerFailure) {
 TEST_F(PrivetConfirmApiFlowTest, BadJson) {
   PrivetConfirmApiCallFlow confirm_flow(request_context_.get(),
                                         &token_service_,
+                                        std::string(),
                                         GURL("http://SoMeUrL.com"),
                                         callback_.callback());