chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc - Issue 23382008: Making OAuth2TokenService multi-login aware, updating callers, minor fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

Issue 23382008: Making OAuth2TokenService multi-login aware, updating callers, minor fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing a unit test, addressing comments from courage@ Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/settings/device_oauth2_token_service.cc ('K') | « chrome/browser/policy/cloud/user_policy_signin_service.cc ('k') | chrome/browser/profiles/profile_downloader.cc » ('j') | chrome/browser/signin/profile_oauth2_token_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

diff --git a/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc b/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

index 8da3550ea65d9f0c29e172360facefadb042db20..da73b556b387a8fa5274a8084cb48fe8dc2e53c7 100644

--- a/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

+++ b/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

@@ -105,12 +105,15 @@ class FakeAndroidProfileOAuth2TokenService

}

// AndroidProfileOAuth2TokenService overrides:

- virtual void FetchOAuth2TokenWithUsername(

+ virtual void FetchOAuth2Token(

RequestImpl* request,

- const std::string& username,

+ const std::string& account_id,

+ net::URLRequestContextGetter* getter,

+ const std::string& client_id,

+ const std::string& client_secret,

const OAuth2TokenService::ScopeSet& scope) OVERRIDE {

ASSERT_TRUE(!HasPendingRequest());

- ASSERT_EQ(kTestUser, username);

+ ASSERT_EQ(kTestUser, account_id);

ASSERT_EQ(2U, scope.size());

EXPECT_EQ(1U, scope.count(GaiaConstants::kDeviceManagementServiceOAuth));

EXPECT_EQ(1U, scope.count(