Making OAuth2TokenService multi-login aware, updating callers, minor fixes

chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h"
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 347 matching lines @@
     owner_key_util_->SetPublicKeyFromPrivateKey(
         *device_policy_.GetNewSigningKey());
     ReloadDeviceSettings();
 
     if (done_)
       return;
 
     // Process robot refresh token store.
     EXPECT_EQ(
         "refreshToken4Test",
-        chromeos::DeviceOAuth2TokenServiceFactory::Get()->GetRefreshToken());
+        chromeos::DeviceOAuth2TokenServiceFactory::Get()->GetRefreshToken(

[Andrew T Wilson (Slow), 2013/08/30 10:47:00]

The fact that there's this unnecessary account_id parameter to
DeviceOAuth2TokenService indicates that we don't quite have the right level of
abstraction - I think the API would have been cleaner if we'd gone down the path
of having separate OAuth2TokenServices per signed-in account (so each O2TS is
inherently tied to a specific account ID).

But I'm OK with this change as-is -- it's workable and we can always do some
future refactoring if this turns out to be cumbersome.

[fgorski, 2013/08/30 20:10:16]

Done. Using GetDeviceAccountId().

+            std::string()));
   }
 
   bool is_auto_enrollment_;
 
   DeviceManagementStatus register_status_;
   em::DeviceManagementResponse register_response_;
 
   DeviceManagementStatus policy_fetch_status_;
   em::DeviceManagementResponse policy_fetch_response_;
 
@@ skipping 108 matching lines @@
 TEST_F(DeviceCloudPolicyManagerChromeOSEnrollmentTest, LoadError) {
   loaded_blob_.clear();
   RunTest();
   ExpectFailedEnrollment(EnrollmentStatus::STATUS_STORE_ERROR);
   EXPECT_EQ(CloudPolicyStore::STATUS_LOAD_ERROR,
             status_.store_status());
 }
 
 }  // namespace
 }  // namespace policy