editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java - Issue 23382007: Fix for 12494

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

Issue 23382007: Fix for 12494 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

index d0a7b54d4824ab8929dcb773b6bc3a89f41fe24a..ed261bf83108ae29ee60e32388543ddc5a9631ef 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

@@ -2583,11 +2583,17 @@ public class ErrorVerifier extends RecursiveASTVisitor<Void> {

return false;

}

boolean hasProblem = false;

- for (MethodElement method : enclosingClass.getMethods()) {

- if (!method.isStatic()) {

+ for (ExecutableElement member : enclosingClass.getMethods()) {

+ if (!member.isStatic()) {

+ continue;

+ }

+ hasProblem |= checkForDuplicateDefinitionInheritance(member);

+ }

+ for (ExecutableElement member : enclosingClass.getAccessors()) {

+ if (!member.isStatic()) {

continue;

}

- hasProblem |= checkForDuplicateDefinitionInheritance(method);

+ hasProblem |= checkForDuplicateDefinitionInheritance(member);

}

return hasProblem;

}