Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2338173006: GN: build get_images_from_skps. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: build get_images_from_skps. This also splits :common_flags off of :flags. get_images_from_skps wants :flags but not :common_flags. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2338173006 Committed: https://skia.googlesource.com/skia/+/046cb56c6c1bb40779c81b115271ed0e8196b48b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M BUILD.gn View 5 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mtklein_C
No harm in getting this in first.
4 years, 3 months ago (2016-09-16 16:17:57 UTC) #5
rmistry
lgtm
4 years, 3 months ago (2016-09-16 17:16:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338173006/1
4 years, 3 months ago (2016-09-16 17:22:18 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 17:23:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/046cb56c6c1bb40779c81b115271ed0e8196b48b

Powered by Google App Engine
This is Rietveld 408576698