Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2338173004: Revert of GN: support 32-bit x86 builds (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio, borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of GN: support 32-bit x86 builds (patchset #6 id:100001 of https://codereview.chromium.org/2340463008/ ) Reason for revert: https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86-Debug-GN_Android/builds/304 Original issue's description: > GN: support 32-bit x86 builds > > Take over Ubuntu -x86- bots. > > Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. > We'll want target_cpu="x86" there too. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 > > Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542 TBR=jcgregorio@google.com,borenet@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/56d5669095feca663e9e05f4621146abeee626ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -71 lines) Patch
M BUILD.gn View 1 chunk +16 lines, -20 lines 0 comments Download
M gn/BUILD.gn View 2 chunks +0 lines, -9 lines 0 comments Download
M infra/bots/recipe_modules/flavor/gn_flavor.py View 3 chunks +1 line, -6 lines 0 comments Download
M infra/bots/recipes/swarm_compile.py View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86-Debug.json View 1 chunk +9 lines, -28 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/failed_compile.json View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein_C
Created Revert of GN: support 32-bit x86 builds
4 years, 3 months ago (2016-09-15 18:18:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338173004/1
4 years, 3 months ago (2016-09-15 18:18:51 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 18:18:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/56d5669095feca663e9e05f4621146abeee626ec

Powered by Google App Engine
This is Rietveld 408576698