Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2338133008: [MD settings] Page title in site details through direct link (Closed)

Created:
4 years, 3 months ago by dschuyler
Modified:
4 years, 3 months ago
Reviewers:
Finnur
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] Page title in site details through direct link This CL moves some code from site_lists.js to site_settings_behavior.js so that it can be used from site_details.js. As a result, we can complete the initialization of the SiteException received in site_details.js and show the URL in that UI. BUG=635874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/949a29bda77e1743a52bf79e45046b17e28f3d3c Cr-Commit-Position: refs/heads/master@{#419216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -49 lines) Patch
M chrome/browser/resources/settings/site_settings/site_details.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.js View 4 chunks +11 lines, -46 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_behavior.js View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dschuyler
4 years, 3 months ago (2016-09-16 01:36:37 UTC) #5
Finnur
Bug link is wrong in CL description... But otherwise LGTM.
4 years, 3 months ago (2016-09-16 14:05:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338133008/1
4 years, 3 months ago (2016-09-16 17:37:27 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 18:12:54 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 18:16:10 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/949a29bda77e1743a52bf79e45046b17e28f3d3c
Cr-Commit-Position: refs/heads/master@{#419216}

Powered by Google App Engine
This is Rietveld 408576698