Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2338133007: Fix build break for Win64 bot. (Closed)

Created:
4 years, 3 months ago by Rahul Chaturvedi
Modified:
4 years, 3 months ago
Reviewers:
Geoff Lang, tbarzic
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build break for Win64 bot. This should fix the build break at this bot: https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20x64%20Builder%20%28dbg%29/builds/9753 R=geofflang@chromium.org TBR=tbarzic@chromium.org BUG=None Committed: https://crrev.com/6772f5bb385df7df099acd276d3fbd687aa7b7ae Cr-Commit-Position: refs/heads/master@{#418926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M extensions/browser/api/printer_provider_internal/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Rahul Chaturvedi
4 years, 3 months ago (2016-09-15 17:35:37 UTC) #1
Geoff Lang
On 2016/09/15 17:35:37, Rahul Chaturvedi wrote: Tested locally, confirmed it fixed the compilation failure on ...
4 years, 3 months ago (2016-09-15 17:46:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338133007/1
4 years, 3 months ago (2016-09-15 17:46:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 19:00:35 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 19:02:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6772f5bb385df7df099acd276d3fbd687aa7b7ae
Cr-Commit-Position: refs/heads/master@{#418926}

Powered by Google App Engine
This is Rietveld 408576698