Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: components/history/core/browser/history_types.h

Issue 2338133006: [NTP] Fix article suggestion clicks contributing to Most Visited tiles (Closed)
Patch Set: Updated trivial occurrence in unit test. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/history_types.h
diff --git a/components/history/core/browser/history_types.h b/components/history/core/browser/history_types.h
index 9795ded30ae0f6bf2100568f573a5c819f5d6fab..64f34c30416fa20c0a6331afc0b638bb5c26274e 100644
--- a/components/history/core/browser/history_types.h
+++ b/components/history/core/browser/history_types.h
@@ -332,7 +332,7 @@ struct MostVisitedURL {
RedirectList redirects;
- bool operator==(const MostVisitedURL& other) {
+ bool operator==(const MostVisitedURL& other) const {
return url == other.url;
}
};
@@ -372,7 +372,7 @@ struct HistoryAddPageArgs {
// HistoryAddPageArgs(
// GURL(), base::Time(), NULL, 0, GURL(),
// RedirectList(), ui::PAGE_TRANSITION_LINK,
- // SOURCE_BROWSED, false)
+ // SOURCE_BROWSED, false, true)
HistoryAddPageArgs();
HistoryAddPageArgs(const GURL& url,
base::Time time,
@@ -382,7 +382,8 @@ struct HistoryAddPageArgs {
const RedirectList& redirects,
ui::PageTransition transition,
VisitSource source,
- bool did_replace_entry);
+ bool did_replace_entry,
+ bool consider_for_ntp_most_visited);
HistoryAddPageArgs(const HistoryAddPageArgs& other);
~HistoryAddPageArgs();
@@ -395,6 +396,11 @@ struct HistoryAddPageArgs {
ui::PageTransition transition;
VisitSource visit_source;
bool did_replace_entry;
+ // Specifies whether a page visit should contribute to the Most Visited tiles
+ // in the New Tab Page. Note that setting this to true (most common case)
+ // doesn't guarantee it's relevant for Most Visited, since other requirements
+ // exist (e.g. certain page transition types).
+ bool consider_for_ntp_most_visited;
};
// TopSites -------------------------------------------------------------------
« no previous file with comments | « components/history/core/browser/history_service.cc ('k') | components/history/core/browser/history_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698