Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: components/history/core/browser/history_types.cc

Issue 2338133006: [NTP] Fix article suggestion clicks contributing to Most Visited tiles (Closed)
Patch Set: Updated trivial occurrence in unit test. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/history/core/browser/history_types.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/history/core/browser/history_types.h" 5 #include "components/history/core/browser/history_types.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 247
248 HistoryAddPageArgs::HistoryAddPageArgs() 248 HistoryAddPageArgs::HistoryAddPageArgs()
249 : HistoryAddPageArgs(GURL(), 249 : HistoryAddPageArgs(GURL(),
250 base::Time(), 250 base::Time(),
251 nullptr, 251 nullptr,
252 0, 252 0,
253 GURL(), 253 GURL(),
254 RedirectList(), 254 RedirectList(),
255 ui::PAGE_TRANSITION_LINK, 255 ui::PAGE_TRANSITION_LINK,
256 SOURCE_BROWSED, 256 SOURCE_BROWSED,
257 false) { 257 false,
258 true) {
258 } 259 }
259 260
260 HistoryAddPageArgs::HistoryAddPageArgs(const GURL& url, 261 HistoryAddPageArgs::HistoryAddPageArgs(const GURL& url,
261 base::Time time, 262 base::Time time,
262 ContextID context_id, 263 ContextID context_id,
263 int nav_entry_id, 264 int nav_entry_id,
264 const GURL& referrer, 265 const GURL& referrer,
265 const RedirectList& redirects, 266 const RedirectList& redirects,
266 ui::PageTransition transition, 267 ui::PageTransition transition,
267 VisitSource source, 268 VisitSource source,
268 bool did_replace_entry) 269 bool did_replace_entry,
270 bool consider_for_ntp_most_visited)
269 : url(url), 271 : url(url),
270 time(time), 272 time(time),
271 context_id(context_id), 273 context_id(context_id),
272 nav_entry_id(nav_entry_id), 274 nav_entry_id(nav_entry_id),
273 referrer(referrer), 275 referrer(referrer),
274 redirects(redirects), 276 redirects(redirects),
275 transition(transition), 277 transition(transition),
276 visit_source(source), 278 visit_source(source),
277 did_replace_entry(did_replace_entry) { 279 did_replace_entry(did_replace_entry),
280 consider_for_ntp_most_visited(consider_for_ntp_most_visited) {
278 } 281 }
279 282
280 HistoryAddPageArgs::HistoryAddPageArgs(const HistoryAddPageArgs& other) = 283 HistoryAddPageArgs::HistoryAddPageArgs(const HistoryAddPageArgs& other) =
281 default; 284 default;
282 285
283 HistoryAddPageArgs::~HistoryAddPageArgs() {} 286 HistoryAddPageArgs::~HistoryAddPageArgs() {}
284 287
285 // ThumbnailMigration --------------------------------------------------------- 288 // ThumbnailMigration ---------------------------------------------------------
286 289
287 ThumbnailMigration::ThumbnailMigration() {} 290 ThumbnailMigration::ThumbnailMigration() {}
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 337
335 void ExpireHistoryArgs::SetTimeRangeForOneDay(base::Time time) { 338 void ExpireHistoryArgs::SetTimeRangeForOneDay(base::Time time) {
336 begin_time = time.LocalMidnight(); 339 begin_time = time.LocalMidnight();
337 340
338 // Due to DST, leap seconds, etc., the next day at midnight may be more than 341 // Due to DST, leap seconds, etc., the next day at midnight may be more than
339 // 24 hours away, so add 36 hours and round back down to midnight. 342 // 24 hours away, so add 36 hours and round back down to midnight.
340 end_time = (begin_time + base::TimeDelta::FromHours(36)).LocalMidnight(); 343 end_time = (begin_time + base::TimeDelta::FromHours(36)).LocalMidnight();
341 } 344 }
342 345
343 } // namespace history 346 } // namespace history
OLDNEW
« no previous file with comments | « components/history/core/browser/history_types.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698