Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 23381002: WheelEvent created using document.createEvent() is not properly initialized (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

WheelEvent created using document.createEvent() is not properly initialized WheelEvent created using document.createEvent() is not properly initialized, its deltaX, deltaY, deltaZ attributes are uninitialized. The specification indicates that those should be initialized to 0. R=arv BUG=227454 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
A LayoutTests/fast/events/wheelevent-document-createevent.html View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/wheelevent-document-createevent-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/dom/WheelEvent.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-21 15:25:34 UTC) #1
arv (Not doing code reviews)
LGTM
7 years, 4 months ago (2013-08-21 16:39:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23381002/1
7 years, 4 months ago (2013-08-21 16:45:58 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-21 17:04:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23381002/1
7 years, 4 months ago (2013-08-21 19:46:28 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-21 20:42:31 UTC) #6
Message was sent while issue was closed.
Change committed as 156500

Powered by Google App Engine
This is Rietveld 408576698