Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Unified Diff: extensions/shell/BUILD.gn

Issue 2338093003: Revert of gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/version_info/BUILD.gn ('k') | ios/crnet/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/BUILD.gn
diff --git a/extensions/shell/BUILD.gn b/extensions/shell/BUILD.gn
index 2be94d510c26f933fb3bf08f24f5996e1d25de91..f14b69607de6b77a642d900c7aa2964059e5efb0 100644
--- a/extensions/shell/BUILD.gn
+++ b/extensions/shell/BUILD.gn
@@ -4,7 +4,11 @@
import("//build/config/features.gni")
import("//build/config/ui.gni")
-import("//build/util/process_version.gni")
+
+# Technically, this directory should not depend on files from src/chrome, but
+# that's where the VERSION file is. This should probably all be moved to
+# src/build.
+import("//chrome/version.gni")
import("//testing/test.gni")
import("//tools/grit/grit_rule.gni")
@@ -276,10 +280,6 @@
process_version("version_header") {
template_file = "common/version.h.in"
- sources = [
- "//build/util/LASTCHANGE",
- "//chrome/VERSION",
- ]
output = "$target_gen_dir/common/version.h"
}
« no previous file with comments | « components/version_info/BUILD.gn ('k') | ios/crnet/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698