Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: chrome/common/BUILD.gn

Issue 2338093003: Revert of gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/chrome_watcher/BUILD.gn ('k') | chrome/installer/gcapi/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/util/process_version.gni")
7 import("//chrome/common/features.gni") 6 import("//chrome/common/features.gni")
8 import("//chrome/process_version_rc_template.gni") # For branding_file_path. 7 import("//chrome/version.gni")
9 import("//mojo/public/tools/bindings/mojom.gni") 8 import("//mojo/public/tools/bindings/mojom.gni")
10 import("//tools/grit/grit_rule.gni") 9 import("//tools/grit/grit_rule.gni")
11 10
12 grit("resources") { 11 grit("resources") {
13 source = "common_resources.grd" 12 source = "common_resources.grd"
14 use_qualified_include = true 13 use_qualified_include = true
15 output_dir = "$root_gen_dir/chrome" 14 output_dir = "$root_gen_dir/chrome"
16 output_name = "common_resources" 15 output_name = "common_resources"
17 outputs = [ 16 outputs = [
18 "grit/common_resources.h", 17 "grit/common_resources.h",
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
503 ] 502 ]
504 } 503 }
505 } 504 }
506 } 505 }
507 506
508 process_version("version_header") { 507 process_version("version_header") {
509 # TODO(brettw) this should have more reduced visibility, but chrome/browser 508 # TODO(brettw) this should have more reduced visibility, but chrome/browser
510 # currently depends on this. 509 # currently depends on this.
511 #visibility = [ ":*" ] 510 #visibility = [ ":*" ]
512 511
513 sources = [ 512 # This one just uses the custom template and no separate sources.
514 "//build/util/LASTCHANGE", 513 sources = []
515 "//chrome/VERSION",
516 branding_file_path,
517 ]
518 template_file = "chrome_version.h.in" 514 template_file = "chrome_version.h.in"
519 515
520 output = "$target_gen_dir/chrome_version.h" 516 output = "$target_gen_dir/chrome_version.h"
521 } 517 }
522 518
523 static_library("constants") { 519 static_library("constants") {
524 sources = [ 520 sources = [
525 "chrome_constants.cc", 521 "chrome_constants.cc",
526 "chrome_constants.h", 522 "chrome_constants.h",
527 "chrome_features.cc", 523 "chrome_features.cc",
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
645 "resource_usage_reporter.mojom", 641 "resource_usage_reporter.mojom",
646 "shell_handler_win.mojom", 642 "shell_handler_win.mojom",
647 ] 643 ]
648 644
649 public_deps = [ 645 public_deps = [
650 "//skia/public/interfaces", 646 "//skia/public/interfaces",
651 ] 647 ]
652 648
653 use_new_wrapper_types = false 649 use_new_wrapper_types = false
654 } 650 }
OLDNEW
« no previous file with comments | « chrome/chrome_watcher/BUILD.gn ('k') | chrome/installer/gcapi/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698