Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: chrome/android/BUILD.gn

Issue 2338093003: Revert of gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/app/version_assembly/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/android/rules.gni") 6 import("//build/config/android/rules.gni")
7 import("//build/util/process_version.gni")
8 import("//build_overrides/v8.gni") 7 import("//build_overrides/v8.gni")
9 import("//chrome/android/chrome_public_apk_tmpl.gni") 8 import("//chrome/android/chrome_public_apk_tmpl.gni")
10 import("//chrome/common/features.gni") 9 import("//chrome/common/features.gni")
11 import("//chrome/process_version_rc_template.gni") # For branding_file_path. 10 import("//chrome/version.gni")
12 import("//testing/test.gni") 11 import("//testing/test.gni")
13 import("//third_party/icu/config.gni") 12 import("//third_party/icu/config.gni")
14 import("//third_party/protobuf/proto_library.gni") 13 import("//third_party/protobuf/proto_library.gni")
15 import("channel.gni") 14 import("channel.gni")
16 import("java_sources.gni") 15 import("java_sources.gni")
17 16
18 manifest_package = "org.chromium.chrome" 17 manifest_package = "org.chromium.chrome"
19 18
20 chrome_public_jinja_variables = default_chrome_public_jinja_variables + 19 chrome_public_jinja_variables = default_chrome_public_jinja_variables +
21 [ "manifest_package=$manifest_package" ] 20 [ "manifest_package=$manifest_package" ]
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 "//ui/android:ui_java", 370 "//ui/android:ui_java",
372 google_play_services_library, 371 google_play_services_library,
373 ] 372 ]
374 srcjar_deps = [ "//base:base_build_config_gen" ] 373 srcjar_deps = [ "//base:base_build_config_gen" ]
375 } 374 }
376 375
377 chrome_version_java_dir = "$root_gen_dir/templates/chrome_version_java" 376 chrome_version_java_dir = "$root_gen_dir/templates/chrome_version_java"
378 chrome_version_java_file = "$chrome_version_java_dir/org/chromium/chrome/browser /ChromeVersionConstants.java" 377 chrome_version_java_file = "$chrome_version_java_dir/org/chromium/chrome/browser /ChromeVersionConstants.java"
379 process_version("chrome_version_java") { 378 process_version("chrome_version_java") {
380 template_file = "java/ChromeVersionConstants.java.version" 379 template_file = "java/ChromeVersionConstants.java.version"
381 sources = [
382 "//chrome/VERSION",
383 branding_file_path,
384 ]
385 output = chrome_version_java_file 380 output = chrome_version_java_file
386 extra_args = [ 381 extra_args = [
387 "-e", 382 "-e",
388 "CHANNEL=str.upper('$android_channel')", 383 "CHANNEL=str.upper('$android_channel')",
389 ] 384 ]
390 } 385 }
391 386
392 zip("chrome_version_srcjar") { 387 zip("chrome_version_srcjar") {
393 inputs = [ 388 inputs = [
394 chrome_version_java_file, 389 chrome_version_java_file,
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
694 instrumentation_test_apk("chrome_sync_shell_test_apk") { 689 instrumentation_test_apk("chrome_sync_shell_test_apk") {
695 apk_name = "ChromeSyncShellTest" 690 apk_name = "ChromeSyncShellTest"
696 apk_under_test = ":chrome_sync_shell_apk" 691 apk_under_test = ":chrome_sync_shell_apk"
697 android_manifest = chrome_sync_shell_test_apk_manifest 692 android_manifest = chrome_sync_shell_test_apk_manifest
698 android_manifest_dep = ":chrome_sync_shell_test_apk_manifest" 693 android_manifest_dep = ":chrome_sync_shell_test_apk_manifest"
699 deps = [ 694 deps = [
700 ":chrome_sync_shell_test_apk_java", 695 ":chrome_sync_shell_test_apk_java",
701 ] 696 ]
702 proguard_enabled = !is_java_debug 697 proguard_enabled = !is_java_debug
703 } 698 }
OLDNEW
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/app/version_assembly/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698