Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Side by Side Diff: chromeos/chromeos_switches.cc

Issue 2338063002: chromeos: Refactor D-Bus client type enum and stub vs. fake naming (Closed)
Patch Set: review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromeos/chromeos_switches.h ('k') | chromeos/dbus/cros_disks_client.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/chromeos_switches.h" 5 #include "chromeos/chromeos_switches.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/metrics/field_trial.h" 10 #include "base/metrics/field_trial.h"
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 94
95 // "Hide" value for kCrosRegionsMode (VPD values are hidden). 95 // "Hide" value for kCrosRegionsMode (VPD values are hidden).
96 const char kCrosRegionsModeHide[] = "hide"; 96 const char kCrosRegionsModeHide[] = "hide";
97 97
98 // Optional value for Data Saver prompt on cellular networks. 98 // Optional value for Data Saver prompt on cellular networks.
99 const char kDataSaverPromptDemoMode[] = "demo"; 99 const char kDataSaverPromptDemoMode[] = "demo";
100 100
101 // Forces the stub implementation of dbus clients. 101 // Forces the stub implementation of dbus clients.
102 const char kDbusStub[] = "dbus-stub"; 102 const char kDbusStub[] = "dbus-stub";
103 103
104 // Comma-spearated list of dbus clients that should be unstubbed. 104 // Comma-separated list of dbus clients that use real implementations, even
105 // See chromeos/dbus/dbus_client_bundle.cc for the names of the dbus clients. 105 // when running on Linux desktop, for example "bluetooth,shill". See
106 // chromeos/dbus/dbus_client_types.cc for names.
107 const char kDbusRealClients[] = "dbus-real-clients";
108
109 // DEPRECATED: Use --dbus-real-clients above.
110 // TODO(jamescook): Delete this code after M56 branches.
106 const char kDbusUnstubClients[] = "dbus-unstub-clients"; 111 const char kDbusUnstubClients[] = "dbus-unstub-clients";
107 112
108 // Indicates that the wallpaper images specified by 113 // Indicates that the wallpaper images specified by
109 // kAshDefaultWallpaper{Large,Small} are OEM-specific (i.e. they are not 114 // kAshDefaultWallpaper{Large,Small} are OEM-specific (i.e. they are not
110 // downloadable from Google). 115 // downloadable from Google).
111 const char kDefaultWallpaperIsOem[] = "default-wallpaper-is-oem"; 116 const char kDefaultWallpaperIsOem[] = "default-wallpaper-is-oem";
112 117
113 // Default large wallpaper to use (as path to trusted, non-user-writable JPEG 118 // Default large wallpaper to use (as path to trusted, non-user-writable JPEG
114 // file). 119 // file).
115 const char kDefaultWallpaperLarge[] = "default-wallpaper-large"; 120 const char kDefaultWallpaperLarge[] = "default-wallpaper-large";
(...skipping 361 matching lines...) Expand 10 before | Expand all | Expand 10 after
477 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); 482 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
478 if (!command_line->HasSwitch(kTestCrosGaiaIdMigration)) 483 if (!command_line->HasSwitch(kTestCrosGaiaIdMigration))
479 return false; 484 return false;
480 485
481 return command_line->GetSwitchValueASCII(kTestCrosGaiaIdMigration) == 486 return command_line->GetSwitchValueASCII(kTestCrosGaiaIdMigration) ==
482 kTestCrosGaiaIdMigrationStarted; 487 kTestCrosGaiaIdMigrationStarted;
483 } 488 }
484 489
485 } // namespace switches 490 } // namespace switches
486 } // namespace chromeos 491 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/chromeos_switches.h ('k') | chromeos/dbus/cros_disks_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698