Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2338013005: Convert editing/inserting/insert-div-02[34].html to use w3c test harness (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/inserting/insert-div-02[34].html to use w3c test harness This patch converts "editing/inserting/insert-div-02[34].html" to use w3c test harness to simplify test script, and consolidates into "insert_paragraph_and_style.html" since these scripts were committed in same patch, for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/8806920ec37672b50c451b3805271f87c12e9440 Cr-Commit-Position: refs/heads/master@{#418812}

Patch Set 1 : 2016-09-14T17:22:14 #

Patch Set 2 : 2016-09-15T10:58:53 #

Total comments: 2

Patch Set 3 : 2016-09-15T15:23:49 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -474 lines) Patch
D third_party/WebKit/LayoutTests/editing/inserting/insert-div-023.html View 1 chunk +0 lines, -54 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/inserting/insert-div-024.html View 1 1 chunk +0 lines, -57 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_and_style.html View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/editing/inserting/insert-div-023-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-023-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-023-expected.txt View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-024-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-024-expected.txt View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.9/editing/inserting/insert-div-023-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-023-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-023-expected.txt View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-024-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-024-expected.txt View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-023-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-023-expected.txt View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-024-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-024-expected.txt View 1 chunk +0 lines, -60 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-09-15 04:17:19 UTC) #11
Xiaocheng
The second test doesn't seem to match the original one. https://codereview.chromium.org/2338013005/diff/20001/third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_and_style.html File third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_and_style.html (right): https://codereview.chromium.org/2338013005/diff/20001/third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_and_style.html#newcode29 ...
4 years, 3 months ago (2016-09-15 05:32:37 UTC) #12
yosin_UTC9
PTAL Update test scenario. https://codereview.chromium.org/2338013005/diff/20001/third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_and_style.html File third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_and_style.html (right): https://codereview.chromium.org/2338013005/diff/20001/third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_and_style.html#newcode29 third_party/WebKit/LayoutTests/editing/inserting/insert_paragraph_and_style.html:29: test(() => assert_selection( On 2016/09/15 ...
4 years, 3 months ago (2016-09-15 08:36:32 UTC) #17
Xiaocheng
lgtm
4 years, 3 months ago (2016-09-15 08:54:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2338013005/40001
4 years, 3 months ago (2016-09-15 09:02:08 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-15 09:07:16 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 09:09:58 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8806920ec37672b50c451b3805271f87c12e9440
Cr-Commit-Position: refs/heads/master@{#418812}

Powered by Google App Engine
This is Rietveld 408576698