Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: net/tools/quic/stateless_rejector.cc

Issue 2338013004: Simplify lifetime management of ValidateClientHelloResultCallback::Result objects (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/stateless_rejector.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/stateless_rejector.cc
diff --git a/net/tools/quic/stateless_rejector.cc b/net/tools/quic/stateless_rejector.cc
index 3c142cedd677b3f75272160615be4a7ef5b1d122..005c335aa2a9059c664d2e330bb56ff706153481 100644
--- a/net/tools/quic/stateless_rejector.cc
+++ b/net/tools/quic/stateless_rejector.cc
@@ -19,12 +19,11 @@ class StatelessRejector::ValidateCallback
~ValidateCallback() override {}
- void RunImpl(const CryptoHandshakeMessage& client_hello,
- const Result& result,
+ void RunImpl(std::unique_ptr<Result> result,
std::unique_ptr<ProofSource::Details> /* proof_source_details */)
override {
StatelessRejector* rejector_ptr = rejector_.get();
- rejector_ptr->ProcessClientHello(client_hello, result, std::move(rejector_),
+ rejector_ptr->ProcessClientHello(*result, std::move(rejector_),
std::move(cb_));
}
@@ -97,7 +96,6 @@ void StatelessRejector::Process(std::unique_ptr<StatelessRejector> rejector,
}
void StatelessRejector::ProcessClientHello(
- const CryptoHandshakeMessage& client_hello,
const ValidateClientHelloResultCallback::Result& result,
std::unique_ptr<StatelessRejector> rejector,
std::unique_ptr<StatelessRejector::ProcessDoneCallback> cb) {
« no previous file with comments | « net/tools/quic/stateless_rejector.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698