Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: net/quic/core/quic_crypto_server_stream.h

Issue 2338013004: Simplify lifetime management of ValidateClientHelloResultCallback::Result objects (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/crypto/quic_crypto_server_config.cc ('k') | net/quic/core/quic_crypto_server_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_crypto_server_stream.h
diff --git a/net/quic/core/quic_crypto_server_stream.h b/net/quic/core/quic_crypto_server_stream.h
index 0fc0a4edf7938df9059fccfca34c13a6c178dc95..8fd5ebab735adf7acb1c9ed2ae36d12248617e89 100644
--- a/net/quic/core/quic_crypto_server_stream.h
+++ b/net/quic/core/quic_crypto_server_stream.h
@@ -125,7 +125,6 @@ class NET_EXPORT_PRIVATE QuicCryptoServerStream
protected:
virtual QuicErrorCode ProcessClientHello(
- const CryptoHandshakeMessage& message,
const ValidateClientHelloResultCallback::Result& result,
std::unique_ptr<ProofSource::Details> proof_source_details,
CryptoHandshakeMessage* reply,
@@ -147,8 +146,7 @@ class NET_EXPORT_PRIVATE QuicCryptoServerStream
void Cancel();
// From ValidateClientHelloResultCallback
- void RunImpl(const CryptoHandshakeMessage& client_hello,
- const Result& result,
+ void RunImpl(std::unique_ptr<Result> result,
std::unique_ptr<ProofSource::Details> details) override;
private:
@@ -179,7 +177,6 @@ class NET_EXPORT_PRIVATE QuicCryptoServerStream
// the client hello is complete. Finishes processing of the client
// hello message and handles handshake success/failure.
void FinishProcessingHandshakeMessage(
- const CryptoHandshakeMessage& message,
const ValidateClientHelloResultCallback::Result& result,
std::unique_ptr<ProofSource::Details> details);
« no previous file with comments | « net/quic/core/crypto/quic_crypto_server_config.cc ('k') | net/quic/core/quic_crypto_server_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698