Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2337983006: Initialize SCT fields. (Closed)

Created:
4 years, 3 months ago by Jeffrey Yasskin
Modified:
4 years, 3 months ago
CC:
chromium-reviews, rsleevi+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri, estark
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize SCT fields. This fixes an MSan error introduced by https://codereview.chromium.org/2294373002/ ==31610==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0xa7ce15a in WriteBytesCommon base/pickle.cc:478:3 #1 0xa7ce15a in WriteBytesStatic<4> base/pickle.cc:443:0 #2 0x98c5407 in WritePOD<int> base/pickle.h:367:5 #3 0x98c5407 in WriteInt base/pickle.h:229:0 #4 0x98c5407 in Persist net/cert/signed_certificate_timestamp.cc:43:0 #5 0x991c383 in Persist net/http/http_response_info.cc:381:18 #6 0x2cb75d0 in TestBody net/http/http_response_info_unittest.cc:111:18 Uninitialized value was stored to memory at #0 0x98c57fd in Persist net/cert/signed_certificate_timestamp.cc:43:3 #1 0x991c383 in Persist net/http/http_response_info.cc:381:18 #2 0x2cb75d0 in TestBody net/http/http_response_info_unittest.cc:111:18 Uninitialized value was created by a heap allocation #0 0x8da8c2 in operator new(unsigned long) ??:0 #1 0xa68c2f8 in GetX509CertSCT net/test/ct_test_util.cc:220:14 #2 0x2cb7451 in TestBody net/http/http_response_info_unittest.cc:104:3 Committed: https://crrev.com/76dfb1eb22ab0435d4e0226057b833fe637281df Cr-Commit-Position: refs/heads/master@{#418956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M net/cert/signed_certificate_timestamp.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Jeffrey Yasskin
4 years, 3 months ago (2016-09-15 19:42:17 UTC) #2
Ryan Sleevi
lgtm
4 years, 3 months ago (2016-09-15 19:42:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337983006/1
4 years, 3 months ago (2016-09-15 19:45:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 20:37:08 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 20:38:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76dfb1eb22ab0435d4e0226057b833fe637281df
Cr-Commit-Position: refs/heads/master@{#418956}

Powered by Google App Engine
This is Rietveld 408576698