Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2190)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java

Issue 2337973005: Mark flaky chrome_public tests with @RetryOnFailure Batch 6 (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java
index c900f9a6b39edf1d1ab1e14cd86ae55bc2979aba..6951ff945997a472fd3aa629acf7ea4bb453f43c 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java
@@ -22,6 +22,7 @@ import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.ThreadUtils;
import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.test.util.Feature;
+import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ShortcutHelper;
import org.chromium.chrome.browser.metrics.WebappUma;
@@ -53,6 +54,7 @@ public class WebappSplashScreenTest extends WebappActivityTestBase {
@SmallTest
@Feature({"Webapps"})
+ @RetryOnFailure
public void testDefaultBackgroundColor() throws Exception {
startWebappActivity();
ViewGroup splashScreen = waitUntilSplashScreenAppears();
@@ -66,6 +68,7 @@ public class WebappSplashScreenTest extends WebappActivityTestBase {
@SmallTest
@Feature({"Webapps"})
@TargetApi(Build.VERSION_CODES.LOLLIPOP)
+ @RetryOnFailure
public void testThemeColorWhenNotSpecified() throws Exception {
startWebappActivity();
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) return;
@@ -75,6 +78,7 @@ public class WebappSplashScreenTest extends WebappActivityTestBase {
@SmallTest
@Feature({"Webapps"})
+ @RetryOnFailure
public void testHidesAfterFirstPaint() throws Exception {
startWebappActivity();
assertTrue(getActivity().isSplashScreenVisibleForTests());
@@ -91,6 +95,7 @@ public class WebappSplashScreenTest extends WebappActivityTestBase {
@SmallTest
@Feature({"Webapps"})
+ @RetryOnFailure
public void testHidesAfterCrash() throws Exception {
startWebappActivity();
assertTrue(getActivity().isSplashScreenVisibleForTests());
@@ -107,6 +112,7 @@ public class WebappSplashScreenTest extends WebappActivityTestBase {
@SmallTest
@Feature({"Webapps"})
+ @RetryOnFailure
public void testHidesAfterLoadCompletes() throws Exception {
startWebappActivity();
assertTrue(getActivity().isSplashScreenVisibleForTests());
@@ -139,6 +145,7 @@ public class WebappSplashScreenTest extends WebappActivityTestBase {
@SmallTest
@Feature({"Webapps"})
+ @RetryOnFailure
public void testHidesAfterMultipleEvents() throws Exception {
startWebappActivity();
assertTrue(getActivity().isSplashScreenVisibleForTests());
@@ -159,6 +166,7 @@ public class WebappSplashScreenTest extends WebappActivityTestBase {
@SmallTest
@Feature({"Webapps"})
+ @RetryOnFailure
public void testUmaOnNativeLoad() throws Exception {
startWebappActivity();
@@ -192,6 +200,7 @@ public class WebappSplashScreenTest extends WebappActivityTestBase {
@SmallTest
@Feature({"Webapps"})
+ @RetryOnFailure
public void testUmaWhenSplashHides() throws Exception {
startWebappActivity();
ThreadUtils.runOnUiThread(new Runnable() {
@@ -220,6 +229,7 @@ public class WebappSplashScreenTest extends WebappActivityTestBase {
@SmallTest
@Feature({"Webapps"})
+ @RetryOnFailure
public void testRegularSplashScreenAppears() throws Exception {
// Register a properly-sized icon for the splash screen.
Context context = getInstrumentation().getTargetContext();
@@ -246,6 +256,7 @@ public class WebappSplashScreenTest extends WebappActivityTestBase {
@SmallTest
@Feature({"Webapps"})
+ @RetryOnFailure
public void testSmallSplashScreenAppears() throws Exception {
// Register a smaller icon for the splash screen.
Context context = getInstrumentation().getTargetContext();

Powered by Google App Engine
This is Rietveld 408576698