Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2337973004: Wordstyle not being used to calculate word width (Closed)

Created:
4 years, 3 months ago by npm
Modified:
4 years, 3 months ago
Reviewers:
dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Delete unused parameter nWordStyle from GetCharWidth() Deleted parameter from callers, who also do not use it. Committed: https://pdfium.googlesource.com/pdfium/+/41d6bbe3d413e7854be89142b70c42a89e315cba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -30 lines) Patch
M core/fpdfdoc/cpdf_variabletext.cpp View 3 chunks +8 lines, -14 lines 0 comments Download
M core/fpdfdoc/ctypeset.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/include/cpdf_variabletext.h View 3 chunks +3 lines, -9 lines 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M fpdfsdk/fxedit/include/fxet_edit.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
npm
PTAL
4 years, 3 months ago (2016-09-14 16:13:37 UTC) #4
dsinclair
lgtm
4 years, 3 months ago (2016-09-14 17:54:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337973004/1
4 years, 3 months ago (2016-09-14 17:54:25 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 18:54:48 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/41d6bbe3d413e7854be89142b70c42a89e31...

Powered by Google App Engine
This is Rietveld 408576698