Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Issue 2337973003: Fix ppapi sample when built on windows. (Closed)

Created:
4 years, 3 months ago by bradnelson
Modified:
4 years, 3 months ago
Reviewers:
bbudge, bradn, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ppapi sample when built on windows. BUG=None TEST=None R=bbudge@chromium.org,sbc@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk Committed: https://crrev.com/04d2b88be73259f63f2956db2df868724928aa61 Cr-Commit-Position: refs/heads/master@{#418895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M native_client_sdk/src/examples/api/vpn_provider/vpn_provider.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 42 (22 generated)
bradn
lgtm
4 years, 3 months ago (2016-09-13 23:08:45 UTC) #2
bradn
Oops, wrong button :-) PTAL
4 years, 3 months ago (2016-09-13 23:09:05 UTC) #3
Sam Clegg
lgtm
4 years, 3 months ago (2016-09-13 23:11:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337973003/1
4 years, 3 months ago (2016-09-13 23:12:12 UTC) #6
bbudge
lgtm
4 years, 3 months ago (2016-09-13 23:12:22 UTC) #7
Sam Clegg
On 2016/09/13 23:11:45, Sam Clegg wrote: > lgtm Can you add `CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk`
4 years, 3 months ago (2016-09-13 23:12:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337973003/1
4 years, 3 months ago (2016-09-13 23:16:50 UTC) #12
commit-bot: I haz the power
Your CL was about to rely on recently removed CQ feature(s): * Specifying master names ...
4 years, 3 months ago (2016-09-13 23:16:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337973003/1
4 years, 3 months ago (2016-09-13 23:18:19 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: master.linux_nacl_sdk on master.tryserver.chromium.linux (JOB_FAILED, no build URL)
4 years, 3 months ago (2016-09-13 23:19:51 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337973003/1
4 years, 3 months ago (2016-09-13 23:45:10 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_nacl_sdk on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_nacl_sdk/builds/778)
4 years, 3 months ago (2016-09-14 01:21:38 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337973003/1
4 years, 3 months ago (2016-09-14 23:25:24 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: mac_nacl_sdk on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) win_nacl_sdk on ...
4 years, 3 months ago (2016-09-15 01:26:52 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337973003/1
4 years, 3 months ago (2016-09-15 06:58:20 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: win_nacl_sdk on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-15 08:58:42 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337973003/1
4 years, 3 months ago (2016-09-15 16:36:19 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337973003/1
4 years, 3 months ago (2016-09-15 17:21:17 UTC) #38
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 17:27:39 UTC) #40
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 17:30:58 UTC) #42
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04d2b88be73259f63f2956db2df868724928aa61
Cr-Commit-Position: refs/heads/master@{#418895}

Powered by Google App Engine
This is Rietveld 408576698