|
|
Created:
4 years, 3 months ago by bradnelson Modified:
4 years, 3 months ago CC:
chromium-reviews, binji+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix ppapi sample when built on windows.
BUG=None
TEST=None
R=bbudge@chromium.org,sbc@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk
Committed: https://crrev.com/04d2b88be73259f63f2956db2df868724928aa61
Cr-Commit-Position: refs/heads/master@{#418895}
Patch Set 1 #
Messages
Total messages: 42 (22 generated)
bradnelson@google.com changed reviewers: + bradnelson@google.com
lgtm
Oops, wrong button :-) PTAL
lgtm
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
On 2016/09/13 23:11:45, Sam Clegg wrote: > lgtm Can you add `CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk`
Description was changed from ========== Fix ppapi sample when built on windows. BUG=None TEST=None R=bbudge@chromium.org,sbc@chromium.org ========== to ========== Fix ppapi sample when built on windows. BUG=None TEST=None R=bbudge@chromium.org,sbc@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk ==========
The CQ bit was unchecked by bradnelson@google.com
The CQ bit was checked by bradnelson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Your CL was about to rely on recently removed CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without "master." prefix is no longer supported: tryserver.chromium.linux tryserver.chromium.mac tryserver.chromium.win For more details, see http://crbug.com/617627.
Description was changed from ========== Fix ppapi sample when built on windows. BUG=None TEST=None R=bbudge@chromium.org,sbc@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk ========== to ========== Fix ppapi sample when built on windows. BUG=None TEST=None R=bbudge@chromium.org,sbc@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:master.linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk ==========
The CQ bit was checked by bradnelson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: master.linux_nacl_sdk on master.tryserver.chromium.linux (JOB_FAILED, no build URL)
Description was changed from ========== Fix ppapi sample when built on windows. BUG=None TEST=None R=bbudge@chromium.org,sbc@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:master.linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk ========== to ========== Fix ppapi sample when built on windows. BUG=None TEST=None R=bbudge@chromium.org,sbc@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk ==========
The CQ bit was checked by bradnelson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_nacl_sdk on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_nacl_sdk/buil...)
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_nacl_sdk on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) win_nacl_sdk on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by bradnelson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_nacl_sdk on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix ppapi sample when built on windows. BUG=None TEST=None R=bbudge@chromium.org,sbc@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk ========== to ========== Fix ppapi sample when built on windows. BUG=None TEST=None R=bbudge@chromium.org,sbc@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk ==========
The CQ bit was unchecked by sbc@chromium.org
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix ppapi sample when built on windows. BUG=None TEST=None R=bbudge@chromium.org,sbc@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk ========== to ========== Fix ppapi sample when built on windows. BUG=None TEST=None R=bbudge@chromium.org,sbc@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix ppapi sample when built on windows. BUG=None TEST=None R=bbudge@chromium.org,sbc@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk ========== to ========== Fix ppapi sample when built on windows. BUG=None TEST=None R=bbudge@chromium.org,sbc@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk Committed: https://crrev.com/04d2b88be73259f63f2956db2df868724928aa61 Cr-Commit-Position: refs/heads/master@{#418895} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/04d2b88be73259f63f2956db2df868724928aa61 Cr-Commit-Position: refs/heads/master@{#418895} |